andresvillenas/Sitecore.Extensions

View on GitHub

Showing 7 of 11 total issues

Function onJumpListClick has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

scContentEditor.prototype.onJumpListClick = function (sender, evt) {
    var ctl = scForm.browser.getSrcElement(evt);

    if (ctl != null) {
        if (ctl.id != null && ctl.id.indexOf("_Glyph_") >= 0) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method RenderPinItem has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private void RenderPinItem(HtmlTextWriter output, Item item, string inner)
        {
            Assert.ArgumentNotNull(output, nameof(output));
            Assert.ArgumentNotNull(item, nameof(item));
            Assert.ArgumentNotNull(inner, nameof(inner));
Severity: Minor
Found in Sitecore.Extensions/ContentEditor/ContentTree/JumpList/JumpList.cs - About 1 hr to fix

    Function onJumpListClick has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    scContentEditor.prototype.onJumpListClick = function (sender, evt) {
        var ctl = scForm.browser.getSrcElement(evt);
    
        if (ctl != null) {
            if (ctl.id != null && ctl.id.indexOf("_Glyph_") >= 0) {

      Method CreateJumpListForUser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private Item CreateJumpListForUser(User user)
              {
                  using (new SecurityDisabler())
                  {
                      try

        Avoid too many return statements within this method.
        Open

                        return CommandState.Hidden;

          Avoid too many return statements within this method.
          Open

                          return CommandState.Hidden;

            Avoid too many return statements within this function.
            Open

                return false;
            Severity: Major
            Found in Sitecore.Extensions/sitecore/shell/Applications/Extensions/JumpList.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language