Sign upLogin

andrewhao/gpx

View on GitHub
Star

Showing 23 of 23 total issues

Method generate_xml_doc has a Cognitive Complexity of 87 (exceeds 5 allowed). Consider refactoring.
Open

    def generate_xml_doc
      @version ||= '1.1'
      version_dir = version.gsub('.','/')

      gpx_header = attributes_and_nsdefs_as_gpx_attributes
Severity: Minor
Found in lib/gpx/gpx_file.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(opts = {})
      @duration = 0
      @attributes = {}
      @namespace_defs = []
      if(opts[:gpx_file] or opts[:gpx_data])
Severity: Minor
Found in lib/gpx/gpx_file.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_xml_doc has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_xml_doc
      @version ||= '1.1'
      version_dir = version.gsub('.','/')

      gpx_header = attributes_and_nsdefs_as_gpx_attributes
Severity: Major
Found in lib/gpx/gpx_file.rb - About 2 hrs to fix

    Method append_point has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def append_point(pt)
      last_pt = @points[-1]
      unless pt.time.nil?
        @earliest_point = pt if(@earliest_point.nil? or pt.time < @earliest_point.time)
        @latest_point   = pt if(@latest_point.nil? or pt.time > @latest_point.time)
    Severity: Minor
    Found in lib/gpx/segment.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def add(item)
      if(item.respond_to?(:lat) and item.respond_to?(:lon))
        @min_lat = item.lat if item.lat < @min_lat
        @min_lon = item.lon if item.lon < @min_lon
        @max_lat = item.lat if item.lat > @max_lat
    Severity: Minor
    Found in lib/gpx/bounds.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def initialize(opts = {})
      @duration = 0
      @attributes = {}
      @namespace_defs = []
      if(opts[:gpx_file] or opts[:gpx_data])
    Severity: Minor
    Found in lib/gpx/gpx_file.rb - About 2 hrs to fix

      Method update_meta_data has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def update_meta_data(pt, last_pt)
      unless pt.time.nil?
        @earliest_point = pt if(@earliest_point.nil? or pt.time < @earliest_point.time)
        @latest_point   = pt if(@latest_point.nil? or pt.time > @latest_point.time)
      end
      Severity: Minor
      Found in lib/gpx/segment.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(opts = {:lat => 0.0, :lon => 0.0, :elevation => 0.0, :time => Time.now } )
      @gpx_file = opts[:gpx_file]
      if (opts[:element])
        elem = opts[:element]
        @lat, @lon = elem["lat"].to_f, elem["lon"].to_f
      Severity: Minor
      Found in lib/gpx/point.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method smooth_location_by_average has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def smooth_location_by_average(opts={})
      seconds_either_side = opts[:averaging_window] || 20

      #calculate the first and last points to which the smoothing should be applied
      earliest = (find_point_by_time_or_offset(opts[:start]) || @earliest_point).time
      Severity: Minor
      Found in lib/gpx/segment.rb - About 1 hr to fix

        Method convert_to_gpx has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def convert_to_gpx(magellan_filename, gpx_filename)

        segment = Segment.new

        CSV.open(magellan_filename, "r").each do |row|
        Severity: Minor
        Found in lib/gpx/magellan_track_log.rb - About 1 hr to fix

          Method find_closest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              def find_closest(pts, time)
      return pts.first if pts.size == 1
      midpoint = pts.size/2
      if pts.size == 2
        diff_1 = pts[0].time - time
          Severity: Minor
          Found in lib/gpx/segment.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method convert_to_gpx has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                def convert_to_gpx(magellan_filename, gpx_filename)

        segment = Segment.new

        CSV.open(magellan_filename, "r").each do |row|
          Severity: Minor
          Found in lib/gpx/magellan_track_log.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def crop(area)
      reset_meta_data
      keep_tracks = []
      tracks.each do |trk|
        trk.crop(area)
          Severity: Minor
          Found in lib/gpx/gpx_file.rb and 1 other location - About 40 mins to fix
          lib/gpx/gpx_file.rb on lines 167..179

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def delete_area(area)
      reset_meta_data
      keep_tracks = []
      tracks.each do |trk|
        trk.delete_area(area)
          Severity: Minor
          Found in lib/gpx/gpx_file.rb and 1 other location - About 40 mins to fix
          lib/gpx/gpx_file.rb on lines 145..157

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method update_meta_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def update_meta_data(trk, get_bounds = true)
      @lowest_point   = trk.lowest_point if(@lowest_point.nil? or (!trk.lowest_point.nil? and trk.lowest_point.elevation < @lowest_point.elevation))
      @highest_point  = trk.highest_point if(@highest_point.nil? or (!trk.highest_point.nil? and trk.highest_point.elevation > @highest_point.elevation))
      @bounds.add(trk.bounds) if get_bounds
      @distance += trk.distance
          Severity: Minor
          Found in lib/gpx/gpx_file.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  @min_lat = item.lat if item.lat < @min_lat
        @min_lon = item.lon if item.lon < @min_lon
        @max_lat = item.lat if item.lat > @max_lat
        @max_lon = item.lon if item.lon > @max_lon
          Severity: Minor
          Found in lib/gpx/bounds.rb and 1 other location - About 30 mins to fix
          lib/gpx/bounds.rb on lines 61..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  @min_lat = item.min_lat if item.min_lat < @min_lat
        @min_lon = item.min_lon if item.min_lon < @min_lon
        @max_lat = item.max_lat if item.max_lat > @max_lat
        @max_lon = item.max_lon if item.max_lon > @max_lon
          Severity: Minor
          Found in lib/gpx/bounds.rb and 1 other location - About 30 mins to fix
          lib/gpx/bounds.rb on lines 56..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this method.
          Open

                  return find_closest(pts[(midpoint+1)..-1], time)
          Severity: Major
          Found in lib/gpx/segment.rb - About 30 mins to fix

            Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def initialize(opts = {})
      if(opts[:element] and opts[:gpx_file])
        wpt_elem = opts[:element]
        @gpx_file = opts[:gpx_file]
        super(:element => wpt_elem, :gpx_file => @gpx_file)
            Severity: Minor
            Found in lib/gpx/waypoint.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                  unless pt.time.nil?
        @earliest_point = pt if(@earliest_point.nil? or pt.time < @earliest_point.time)
        @latest_point   = pt if(@latest_point.nil? or pt.time > @latest_point.time)
      end
            Severity: Minor
            Found in lib/gpx/segment.rb and 3 other locations - About 20 mins to fix
            lib/gpx/segment.rb on lines 60..63
            lib/gpx/segment.rb on lines 64..67
            lib/gpx/segment.rb on lines 243..246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language