Sign upLogin

andreychernih/railsbox

View on GitHub
Star

Showing 8 of 8 total issues

Method get has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get(platform = :mac)
    app_name = 'myapp'
    user_name = 'vagrant'
    server_configuration = {
        target: 'server',
Severity: Major
Found in lib/default_configuration.rb - About 2 hrs to fix

    Method save has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def save(output_dir)
      process_recursive(Templates::ROOT_PATH, '', output_dir) do |source_path, target_path|
        custom_rules.each do |k, v|
          if source_path.include?(k)
            target_path = v ? target_path.gsub(k, v) : nil
    Severity: Minor
    Found in app/domain/compilers/copy.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if self.current is not None:
            # Record the running time of the last executed task
            self.stats[self.current] = time.time() - self.stats[self.current]
    Severity: Major
    Found in templates/ansible/callback_plugins/profile_tasks.py and 1 other location - About 1 hr to fix
    templates/ansible/callback_plugins/profile_tasks.py on lines 29..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if self.current is not None:
            self.stats[self.current] = time.time() - self.stats[self.current]
    Severity: Major
    Found in templates/ansible/callback_plugins/profile_tasks.py and 1 other location - About 1 hr to fix
    templates/ansible/callback_plugins/profile_tasks.py on lines 16..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method cleanup has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.cleanup(hash)
    bare = {}

    hash.each do |k, v|
      if v.is_a?(Array)
    Severity: Minor
    Found in lib/default_configuration.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def save(output_dir)
      environments.each do |env|
        env_params = {rails_env: env}.merge(@params[env.to_sym])
        env_path = File.join(output_dir, env)
        FileUtils.mkdir_p env_path
    Severity: Minor
    Found in app/domain/compilers/environments.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_recursive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_recursive(zipfile, dir)
        Dir.foreach(dir) do |f|
          next if f.in?(['.', '..'])
          full_path = File.join(dir, f)
          relative_path = full_path.gsub(@dir.to_s, '').gsub(/^\//, '')
    Severity: Minor
    Found in app/domain/services/download.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process_recursive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def process_recursive(source_dir, source_path, output_dir, &block)
      Dir.foreach(File.join(source_dir, source_path)) do |f|
        next if f.in?(['.', '..'])

        full_path = File.join(source_dir, source_path, f)
    Severity: Minor
    Found in app/domain/compilers/base.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language