Sign upLogin

andreypostal/cli

View on GitHub
Star

Showing 47 of 58 total issues

Method loopInfiniteBar has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loopInfiniteBar(int $totalSteps = 20, int $blockSize = 3): void
    {
        $step = floor($this->barSize / $totalSteps);

        $originalBlockSize = $blockSize;
Severity: Minor
Found in src/Components/InfiniteProgressBar.php - About 1 hr to fix

    Method oneHandler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function oneHandler(Context $context): void
    {
        self::console('Just starting');

        // Recover the parameter by the key
    Severity: Minor
    Found in examples/Complete/MyService.php - About 1 hr to fix

      Function loopInfiniteBar has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function loopInfiniteBar(int $totalSteps = 20, int $blockSize = 3): void
    {
        $step = floor($this->barSize / $totalSteps);

        $originalBlockSize = $blockSize;
      Severity: Minor
      Found in src/Components/InfiniteProgressBar.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method loopInfiniteBar uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                    $nLeftSpaces += $this->barSize - $sumSpaces;
                }
      Severity: Minor
      Found in src/Components/InfiniteProgressBar.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Call to undeclared method \Andrey\Cli\Examples\InfiniteProgressBar\Service::loopInfiniteBar
      Open

                  $this->loopInfiniteBar();
      Severity: Critical
      Found in examples/InfiniteProgressBar/Service.php by phan

      Call to undeclared method \Andrey\Cli\Examples\ProgressBar\Service::endProgressBar
      Open

              $this->endProgressBar();
      Severity: Critical
      Found in examples/ProgressBar/Service.php by phan

      syntax error, unexpected 'ConsoleLevel' (T_STRING)
      Open

      enum ConsoleLevel
      Severity: Critical
      Found in src/Types/ConsoleLevel.php by phan

      syntax error, unexpected ')'
      Open

              );
      Severity: Critical
      Found in src/Utils/Output.php by phan

      Reference to constant INFO from undeclared class \Andrey\Cli\Types\ConsoleLevel
      Open

              self::center('And we are done :)', ConsoleLevel::INFO);
      Severity: Critical
      Found in examples/InfiniteProgressBar/Service.php by phan

      Static call to undeclared method \Andrey\Cli\Examples\BasicService\Service::console
      Open

              self::console("Look at this nice param --> {$arg} <--");
      Severity: Critical
      Found in examples/BasicService/Service.php by phan

      Call to method get from undeclared class \Andrey\Cli\Types\Context
      Open

              $thisExists = $context->get('required');
      Severity: Critical
      Found in examples/ParamsValidation/Service.php by phan

      Static call to undeclared method \Andrey\Cli\Examples\ParamsValidation\Service::console
      Open

              self::console("Check it out: >> {$thisExists} <<", ConsoleLevel::SUCCESS);
      Severity: Critical
      Found in examples/ParamsValidation/Service.php by phan

      syntax error, unexpected 'public' (T_PUBLIC), expecting variable (T_VARIABLE)
      Open

              public string $key,
      Severity: Critical
      Found in src/Types/Command.php by phan

      syntax error, unexpected 'class' (T_CLASS)
      Open

      readonly class Context
      Severity: Critical
      Found in src/Types/Context.php by phan

      syntax error, unexpected ')'
      Open

              );
      Severity: Critical
      Found in examples/BooleanFlag/Service.php by phan

      Reference to constant HIGHLIGHT from undeclared class \Andrey\Cli\Types\ConsoleLevel
      Open

              self::center('Check this really nice infinite progress bar', ConsoleLevel::HIGHLIGHT);
      Severity: Critical
      Found in examples/InfiniteProgressBar/Service.php by phan

      Reference to constant WARNING from undeclared class \Andrey\Cli\Types\ConsoleLevel
      Open

                  self::console("OH NO >.<", ConsoleLevel::WARNING);
      Severity: Critical
      Found in examples/ParamsValidation/Service.php by phan

      Parameter $context has undeclared type \Andrey\Cli\Types\Context
      Open

          public function process(Context $context): void
      Severity: Minor
      Found in examples/ProgressBar/Service.php by phan

      syntax error, unexpected 'class' (T_CLASS)
      Open

      readonly class MyCommand extends App
      Severity: Critical
      Found in examples/Complete/MyCommand.php by phan

      syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
      Open

          private int $totalItems;
      Severity: Critical
      Found in src/Components/ProgressBar.php by phan
      Severity
      Category
      Status
      Source
      Language