Sign upLogin

anephenix/hub

View on GitHub
Star

Showing 87 of 87 total issues

Identical blocks of code found in 9 locations. Consider refactoring.
Open

            hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

            hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        ws.on('error', (error) => {
            connectionEventListeners.error.forEach((func) =>
                func({ error, ws })
            );
        });
Severity: Major
Found in lib/index.js and 2 other locations - About 50 mins to fix
lib/index.js on lines 160..164
lib/index.js on lines 166..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        ws.on('message', (message) => {
            connectionEventListeners.message.forEach((func) =>
                func({ message, ws })
            );
        });
Severity: Major
Found in lib/index.js and 2 other locations - About 50 mins to fix
lib/index.js on lines 166..170
lib/index.js on lines 172..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

                hubClient.sarus.on('message', (event) => {
                    const message = JSON.parse(event.data);
                    messages.push(message);
                });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

                hubClient.sarus.on('message', (event) => {
                    const message = JSON.parse(event.data);
                    messages.push(message);
                });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

            hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

            hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

            hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

            hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
Severity: Major
Found in __tests__/index.test.js and 8 other locations - About 50 mins to fix
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 330..333
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 9 locations. Consider refactoring.
Open

                hubClient.sarus.on('message', (event) => {
                    const message = JSON.parse(event.data);
                    messages.push(message);
                });
Severity: Major
Found in __tests__/lib/pubsub.test.js and 8 other locations - About 50 mins to fix
__tests__/index.test.js on lines 309..312
__tests__/lib/pubsub.test.js on lines 157..160
__tests__/lib/pubsub.test.js on lines 196..199
__tests__/lib/pubsub.test.js on lines 236..239
__tests__/lib/pubsub.test.js on lines 299..302
__tests__/lib/pubsub.test.js on lines 361..364
__tests__/lib/pubsub.test.js on lines 498..501
__tests__/lib/pubsub.test.js on lines 575..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                assert.rejects(
                    async () => {
                        await hub.pubsub.subscribe({ data, socket });
                    },
                    { message: 'No channel was passed in the data' }
Severity: Minor
Found in __tests__/lib/pubsub.test.js and 1 other location - About 50 mins to fix
__tests__/lib/pubsub.test.js on lines 70..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                assert.rejects(
                    async () => {
                        await hub.pubsub.subscribe({ data, socket });
                    },
                    { message: 'No client id was found on the WebSocket' }
Severity: Minor
Found in __tests__/lib/pubsub.test.js and 1 other location - About 50 mins to fix
__tests__/lib/pubsub.test.js on lines 85..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    async removeClientFromChannel({ clientId, channel }) {
        await this.performActionForClientAndChannel({
            action: 'removeItemFromCollection',
            clientId,
            channel,
Severity: Major
Found in lib/dataStores/memory.js and 3 other locations - About 40 mins to fix
lib/dataStores/memory.js on lines 54..60
lib/dataStores/redis.js on lines 82..88
lib/dataStores/redis.js on lines 90..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        this.wss.on('error', (event) => {
            this.serverEventListeners.error.forEach((func) => func(event));
        });
Severity: Major
Found in lib/index.js and 3 other locations - About 40 mins to fix
lib/index.js on lines 192..194
lib/index.js on lines 200..202
lib/index.js on lines 204..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        this.wss.on('headers', (event) => {
            this.serverEventListeners.headers.forEach((func) => func(event));
        });
Severity: Major
Found in lib/index.js and 3 other locations - About 40 mins to fix
lib/index.js on lines 192..194
lib/index.js on lines 196..198
lib/index.js on lines 200..202

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        this.wss.on('listening', (event) => {
            this.serverEventListeners.listening.forEach((func) => func(event));
        });
Severity: Major
Found in lib/index.js and 3 other locations - About 40 mins to fix
lib/index.js on lines 192..194
lib/index.js on lines 196..198
lib/index.js on lines 204..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    async addClientToChannel({ clientId, channel }) {
        await this.performActionForClientAndChannel({
            action: 'addItemToCollection',
            clientId,
            channel,
Severity: Major
Found in lib/dataStores/redis.js and 3 other locations - About 40 mins to fix
lib/dataStores/memory.js on lines 54..60
lib/dataStores/memory.js on lines 62..68
lib/dataStores/redis.js on lines 90..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    async addClientToChannel({ clientId, channel }) {
        await this.performActionForClientAndChannel({
            action: 'addItemToCollection',
            clientId,
            channel,
Severity: Major
Found in lib/dataStores/memory.js and 3 other locations - About 40 mins to fix
lib/dataStores/memory.js on lines 62..68
lib/dataStores/redis.js on lines 82..88
lib/dataStores/redis.js on lines 90..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    async removeClientFromChannel({ clientId, channel }) {
        await this.performActionForClientAndChannel({
            action: 'removeItemFromCollection',
            clientId,
            channel,
Severity: Major
Found in lib/dataStores/redis.js and 3 other locations - About 40 mins to fix
lib/dataStores/memory.js on lines 54..60
lib/dataStores/memory.js on lines 62..68
lib/dataStores/redis.js on lines 82..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language