Sign upLogin

angelakuo/citydogshare

View on GitHub
Star
db/migrate/201503291520_create_dogs.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method has too many lines. [41/10]
Open

    def change
        create_table :dogs do |t|
            t.string :name
            t.string :image
            t.datetime :dob
Severity: Minor
Found in db/migrate/201503291520_create_dogs.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for change is too high. [32/15]
Open

    def change
        create_table :dogs do |t|
            t.string :name
            t.string :image
            t.datetime :dob
Severity: Minor
Found in db/migrate/201503291520_create_dogs.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method change has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def change
        create_table :dogs do |t|
            t.string :name
            t.string :image
            t.datetime :dob
Severity: Minor
Found in db/migrate/201503291520_create_dogs.rb - About 1 hr to fix

    Use 2 (not 4) spaces for indentation.
    Open

        def change
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Use 2 (not 4) spaces for indentation.
    Open

                t.integer :dog_id
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Use 2 (not 4) spaces for indentation.
    Open

                t.string :value
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Use 2 (not 4) spaces for indentation.
    Open

                t.string :value
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Missing top-level class documentation comment.
    Open

    class CreateDogs < ActiveRecord::Migration
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

    Use 2 (not 4) spaces for indentation.
    Open

                t.string :value
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Trailing whitespace detected.
    Open
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    Use 2 (not 4) spaces for indentation.
    Open

                t.string :value
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Use 2 (not 4) spaces for indentation.
    Open

                t.integer :dog_id
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Use 2 (not 4) spaces for indentation.
    Open

                t.string :value
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Use 2 (not 4) spaces for indentation.
    Open

                t.integer :dog_id
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Use 2 (not 4) spaces for indentation.
    Open

            create_table :dogs do |t|
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    Use 2 (not 4) spaces for indentation.
    Open

                t.string :name
    Severity: Minor
    Found in db/migrate/201503291520_create_dogs.rb by rubocop

    This cops checks for indentation that doesn't use the specified number of spaces.

    See also the IndentationConsistency cop which is the companion to this one.

    Example:

    # bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

    Example: IgnoredPatterns: ['^\s*module']

    # bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

    There are no issues that match your filters.

    Category
    Status