Sign upLogin

angelakuo/citydogshare

View on GitHub
Star

Showing 3,976 of 3,976 total issues

Function easeOutCubic has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    easeOutCubic: function (x, t, b, c, d) {
Severity: Minor
Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

    Function easeInOutCubic has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        easeInOutCubic: function (x, t, b, c, d) {
    Severity: Minor
    Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

      Function easeInOutQuad has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          easeInOutQuad: function (x, t, b, c, d) {
      Severity: Minor
      Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

        Function easeInCirc has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            easeInCirc: function (x, t, b, c, d) {
        Severity: Minor
        Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

          Function easeOutBounce has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              easeOutBounce: function (x, t, b, c, d) {
          Severity: Minor
          Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

            Function easeOutExpo has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                easeOutExpo: function (x, t, b, c, d) {
            Severity: Minor
            Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

              Function easeInQuart has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  easeInQuart: function (x, t, b, c, d) {
              Severity: Minor
              Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

                Function easeOutCirc has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    easeOutCirc: function (x, t, b, c, d) {
                Severity: Minor
                Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

                  Function easeInQuint has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      easeInQuint: function (x, t, b, c, d) {
                  Severity: Minor
                  Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

                    Function easeInOutCirc has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        easeInOutCirc: function (x, t, b, c, d) {
                    Severity: Minor
                    Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

                      Function easeInOutQuart has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          easeInOutQuart: function (x, t, b, c, d) {
                      Severity: Minor
                      Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

                        Function easeOutQuint has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            easeOutQuint: function (x, t, b, c, d) {
                        Severity: Minor
                        Found in public/assets/materialize/jquery.easing.1.3-d5b95b9fc4fb169022b9626a89923093ead7141ec9fe981e173c4efc1207410f.js - About 35 mins to fix

                          Function _dialogDatepicker has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              _dialogDatepicker: function(input, date, onSelect, settings, pos) {
                          Severity: Minor
                          Found in public/assets/jquery-ui-ef9b962e869a815adb51e633eb7d5cc5ddb8bdad94e97ad2461759d77273e9fa.js - About 35 mins to fix

                            Function switchClass has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                switchClass: function( remove, add, speed, easing, callback) {
                            Severity: Minor
                            Found in public/assets/jquery-ui-ef9b962e869a815adb51e633eb7d5cc5ddb8bdad94e97ad2461759d77273e9fa.js - About 35 mins to fix

                              Function ArrayContaining has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              getJasmineRequireObj().ArrayContaining = function(j$) {
  function ArrayContaining(sample) {
    this.sample = sample;
  }
                              Severity: Minor
                              Found in public/assets/jasmine-3381524e041727d93e4b14f37a44f36704129672035b60bc98fbf476d6d011da.js - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method valid_start_end_dates? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                                def valid_start_end_dates?
    errors.add(:start_date, "Start date has passed") if start_date.present? and Date.today > start_date
    errors.add(:end_date, "End date has passed") if end_date.present? and Date.today > end_date
    if start_date.present? and end_date.present?
      errors.add(:start_end_date, "Start date must be before end date") if start_date > end_date
                              Severity: Minor
                              Found in app/models/event.rb - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method all_info has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                                def all_info
    filtered_dogs_hash = Dog.all.select { |dog|
      valid_dog = true
      if params[:available] == "true" && !dog.available then valid_dog = false end
      if params[:available] == "false" && dog.available then valid_dog = false end
                              Severity: Minor
                              Found in app/controllers/dogs_controller.rb - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                def info
    id = params[:id]
    if !Dog.exists?(id)
      render :json => {
        "success" => false,
                              Severity: Minor
                              Found in app/controllers/dogs_controller.rb and 1 other location - About 35 mins to fix
                              app/controllers/users_controller.rb on lines 39..50

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 35.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                def info
    id = params[:id]
    if !User.exists?(id)
      render :json => { "success" => false, "message" => "User not found"}
    else
                              Severity: Minor
                              Found in app/controllers/users_controller.rb and 1 other location - About 35 mins to fix
                              app/controllers/dogs_controller.rb on lines 25..39

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 35.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Avoid too many return statements within this function.
                              Open

                                                  return results;
                              Severity: Major
                              Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language