angelakuo/citydogshare

View on GitHub

Showing 3,976 of 3,976 total issues

Assignment Branch Condition size for edit is too high. [34.48/15]
Open

  def edit
    flash[:notice] = "All information added here will be visible to other members."
    if @current_user.dogs.empty?
      flash[:notice] = "Please update your zipcode to add a dog. All information added here will be visible to other members."
    end
Severity: Minor
Found in app/controllers/users_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

`` has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

{
    def: 'easeOutQuad',
    swing: function (x, t, b, c, d) {
        //alert(jQuery.easing.default);
        return jQuery.easing[jQuery.easing.def](x, t, b, c, d);

    `` has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    {
        def: 'easeOutQuad',
        swing: function (x, t, b, c, d) {
            //alert(jQuery.easing.default);
            return jQuery.easing[jQuery.easing.def](x, t, b, c, d);

      `` has 31 functions (exceeds 20 allowed). Consider refactoring.
      Open

      {
          def: 'easeOutQuad',
          swing: function (x, t, b, c, d) {
              //alert(jQuery.easing.default);
              return jQuery.easing[jQuery.easing.def](x, t, b, c, d);

        Assignment Branch Condition size for params_hash is too high. [33.2/15]
        Open

          def params_hash
            # FullCalendar updates end_date off by 1 day
            if params["fc_update"]
              attributes = 
              { :start_date => params["event"]["start_date"],

        This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

        Function Clock has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        getJasmineRequireObj().Clock = function() {
          function Clock(global, delayedFunctionSchedulerFactory, mockDate) {
            var self = this,
              realTimingFunctions = {
                setTimeout: global.setTimeout,

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toast has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        ;Materialize.toast = function (message, displayLength, className, completeCallback) {
            className = className || "";
        
            var container = document.getElementById('toast-container');
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toast has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        Materialize.toast = function (message, displayLength, className, completeCallback) {
            className = className || "";
        
            var container = document.getElementById('toast-container');
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toast has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        Materialize.toast = function (message, displayLength, className, completeCallback) {
            className = className || "";
        
            var container = document.getElementById('toast-container');
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function trigger has 93 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            trigger: function( event, data, elem, onlyHandlers ) {
                var handle, ontype, cur,
                    bubbleType, special, tmp, i,
                    eventPath = [ elem || document ],
                    type = hasOwn.call( event, "type" ) ? event.type : event,

          Function Animation has 92 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function Animation( elem, properties, options ) {
              var result,
                  stopped,
                  index = 0,
                  length = Animation.prefilters.length,

            Function Animation has 92 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function Animation( elem, properties, options ) {
                var result,
                    stopped,
                    index = 0,
                    length = Animation.prefilters.length,

              Function Animation has 92 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function Animation( elem, properties, options ) {
                  var result,
                      stopped,
                      index = 0,
                      length = Animation.prefilters.length,

                Consider simplifying this complex logical expression.
                Open

                                            if (((key >= KEY0 && key <= KEY9) || (key >= _KEY0 && key <= _KEY9)) || (key === BACKSPACE || key === DEL)) {
                                                pos = getCaretPos(this);
                                                digit = (key !== BACKSPACE && key !== DEL) ? String.fromCharCode((_KEY0 <= key && key <= _KEY9) ? key - KEY0 : key) : '_';
                
                                                if ((key === BACKSPACE || key === DEL) && pos) {

                  Assignment Branch Condition size for change is too high. [32/15]
                  Open

                      def change
                          create_table :dogs do |t|
                              t.string :name
                              t.string :image
                              t.datetime :dob

                  This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

                  Function _fetchEventSource has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function _fetchEventSource(source, callback) {
                          var i;
                          var fetchers = FC.sourceFetchers;
                          var res;
                  
                  

                    Function identifierToken has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        Lexer.prototype.identifierToken = function() {
                          var alias, colon, colonOffset, forcedIdentifier, id, idLength, input, match, poppedToken, prev, ref2, ref3, ref4, ref5, tag, tagToken;
                          if (!(match = IDENTIFIER.exec(this.chunk))) {
                            return 0;
                          }

                      Function toast has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      ;Materialize.toast = function (message, displayLength, className, completeCallback) {
                          className = className || "";
                      
                          var container = document.getElementById('toast-container');
                      
                      

                        Function toast has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        Materialize.toast = function (message, displayLength, className, completeCallback) {
                            className = className || "";
                        
                            var container = document.getElementById('toast-container');
                        
                        

                          Function toast has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          Materialize.toast = function (message, displayLength, className, completeCallback) {
                              className = className || "";
                          
                              var container = document.getElementById('toast-container');
                          
                          
                            Severity
                            Category
                            Status
                            Source
                            Language