Sign upLogin

angelakuo/citydogshare

View on GitHub
Star

Showing 3,976 of 3,976 total issues

Function toHaveBeenCalled has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

getJasmineRequireObj().toHaveBeenCalled = function(j$) {

  var getErrorMsg = j$.formatErrorMsg('<toHaveBeenCalled>', 'expect(<spyObj>).toHaveBeenCalled()');

  function toHaveBeenCalled() {
Severity: Minor
Found in public/assets/jasmine-3381524e041727d93e4b14f37a44f36704129672035b60bc98fbf476d6d011da.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    @event = Event.find(params[:id])
    if not @is_admin and @event.user != @current_user
      flash[:notice] = "You may not edit another person's event."
      redirect_to events_path
Severity: Minor
Found in app/controllers/events_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

var access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
Severity: Major
Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 50 mins to fix

    Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    var access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
    Severity: Major
    Found in public/assets/jquery3-d4bd3e85283a3dca94d4167d510fa09702db65cbbcbd798b3ace19480bc43025.js - About 50 mins to fix

      Function performAction has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      performAction: function anonymous(yytext, yyleng, yylineno, yy, yystate /* action[1] */, $$ /* vstack */, _$ /* lstack */) {
      Severity: Major
      Found in public/assets/coffee-script-fa18d8dbf4c27c69f9d47bba7692b38a18dc2ce3fe2f10421cf4950551851c62.js - About 50 mins to fix

        Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        var access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
        Severity: Major
        Found in public/assets/jquery-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js - About 50 mins to fix

          Function createDate has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function createDate (y, m, d, h, M, s, ms) {
          Severity: Major
          Found in public/assets/moment-14a05e94cca93048a2a57289c5b322ce9bf419e4689a57a7b33fae4066d867e9.js - About 50 mins to fix

            Function createDate has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function createDate (y, m, d, h, M, s, ms) {
            Severity: Major
            Found in public/assets/moment-0da3eb4ebf8fb8c3113d89afb90e5b7a87760d21b5b39a405a51fe05c8e40fd8.js - About 50 mins to fix

              Block has too many lines. [31/25]
              Open

              Citydogshare::Application.configure do
  # Settings specified here will take precedence over those in config/application.rb
  
  config.eager_load = false
  # The test environment is used exclusively to run your application's
              Severity: Minor
              Found in config/environments/test.rb by rubocop

              This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

              Avoid deeply nested control flow statements.
              Open

                                      if ( (elem = matcherOut[i]) ) {
                            // Restore matcherIn since elem is not yet a final match
                            temp.push( (matcherIn[i] = elem) );
                        }
              Severity: Major
              Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if ( !selector ) {
                        push.apply( results, seed );
                        return results;
                    }
                Severity: Major
                Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if ( ( event.result = ret ) === false ) {
                            event.preventDefault();
                            event.stopPropagation();
                        }
                  Severity: Major
                  Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                    } else if ( copy !== undefined ) {
                    target[ name ] = copy;
                }
                    Severity: Major
                    Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if ( cur.indexOf( " " + clazz + " " ) < 0 ) {
                            cur += clazz + " ";
                        }
                      Severity: Major
                      Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if ( rscriptType.test( node.type || "" ) &&
                        !dataPriv.access( node, "globalEval" ) &&
                        jQuery.contains( doc, node ) ) {

                        if ( node.src ) {
                        Severity: Major
                        Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                          Function mutateEvents has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              function mutateEvents(events, clearEnd, allDay, dateDelta, durationDelta, miscProps) {
                          Severity: Minor
                          Found in public/assets/fullcalendar-a27fb9d257cc1270a14286cedb01a2357bcfe0c2906272a7b25da53b68691440.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                                if ( ( ofType ?
                                        node.nodeName.toLowerCase() === name :
                                        node.nodeType === 1 ) &&
                                        ++diff ) {
                            Severity: Major
                            Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      for ( match in context ) {

                            // Properties of context are called as methods if possible
                            if ( jQuery.isFunction( this[ match ] ) ) {
                                this[ match ]( context[ match ] );
                              Severity: Major
                              Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                    if ( conv && s.throws ) {
                        response = conv( response );
                    } else {
                        try {
                            response = conv( response );
                                Severity: Major
                                Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix

                                  Function setMatcher has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  function setMatcher( preFilter, selector, matcher, postFilter, postFinder, postSelector ) {
                                  Severity: Minor
                                  Found in public/assets/jquery2-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js - About 45 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language