Sign upLogin

angelxmoreno/doba-api

View on GitHub
Star
src/Factory.php

Summary

Maintainability
A
35 mins
Test Coverage
C
78%

Method buildClient has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $username,
        string $password,
        string $retailer_id,
        string $type = Factory::PRODUCT,
        bool $dev_mode = true
Severity: Minor
Found in src/Factory.php - About 35 mins to fix

The method buildClient has a boolean flag argument $dev_mode, which is a certain sign of a Single Responsibility Principle violation.
Open

        bool $dev_mode = true
Severity: Minor
Found in src/Factory.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '63', column '23').
Open

            throw new \InvalidArgumentException(sprintf(
Severity: Minor
Found in src/Factory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method buildApi has a boolean flag argument $dev_mode, which is a certain sign of a Single Responsibility Principle violation.
Open

        bool $dev_mode = true
Severity: Minor
Found in src/Factory.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status