Sign upLogin

anilmaurya/bidder

View on GitHub
Star
app/controllers/game_moves_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method game_result has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def game_result
    @game_move.update_attributes(player_1_bid: @game.player_1.next_move(@game.player_2.current_amount, @game.level)) if @game.practise
    if @game_move.player_1_bid && @game_move.player_2_bid
      process_game
      @new_game_move = GameMove.create(game_id: @game.id)
Severity: Minor
Found in app/controllers/game_moves_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_winner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def find_winner
    if @game.level == 1 || @game.level == 7
      @win = @game.level == 1 ? @game.player_1 : @game.player_2
    else
      check_if_any_player_reaches_zero
Severity: Minor
Found in app/controllers/game_moves_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method push_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def push_response
    Pusher['presence-gamemove'].trigger("move_#{another_player.user.id.to_s}", {win: @win, winner: @win ? @win.is_a?(Player) ? (@win.name || @win.username).humanize : 'draw' : '', result: @result, current_amount: @player.current_amount, new_game_move_path: "/game_moves/#{@new_game_move.id}", player_1_amount: @player1.current_amount, player_2_amount: @player2.current_amount, current_player: @player})
  end
Severity: Minor
Found in app/controllers/game_moves_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status