Sign upLogin

anoobbava/approval_system

View on GitHub
Star
app/models/request_approval.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use each_value instead of each.
Open

      reuests_hash.each do |_key, value|
Severity: Minor
Found in app/models/request_approval.rb by rubocop

This cop checks for uses of each_key and each_value Hash methods.

Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

Example:

# bad
hash.keys.each { |k| p k }
hash.values.each { |v| p v }
hash.each { |k, _v| p k }
hash.each { |_k, v| p v }

# good
hash.each_key { |k| p k }
hash.each_value { |v| p v }

Line is too long. [107/80]
Open

  scope :to_be_approved, ->(user) { where 'approver_id = ? AND approved_status = ?', user, 'NOT APPROVED' }
Severity: Minor
Found in app/models/request_approval.rb by rubocop

There are no issues that match your filters.

Category
Status