Sign upLogin

ant-design/ant-design

View on GitHub
Star
components/table/hooks/useSelection.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Function useSelection has 535 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const useSelection = <RecordType extends AnyObject = AnyObject>(
  config: UseSelectionConfig<RecordType>,
  rowSelection?: TableRowSelection<RecordType>,
): readonly [TransformColumns<RecordType>, Set<Key>] => {
  const {
Severity: Major
Found in components/table/hooks/useSelection.tsx - About 2 days to fix

    Function transformColumns has 279 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        (columns: ColumnsType<RecordType>): ColumnsType<RecordType> => {
      // >>>>>>>>>>> Skip if not exists `rowSelection`
      if (!rowSelection) {
        warning(
          !columns.includes(SELECTION_COLUMN),
    Severity: Major
    Found in components/table/hooks/useSelection.tsx - About 1 day to fix

      Function useSelection has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
      Open

      const useSelection = <RecordType extends AnyObject = AnyObject>(
  config: UseSelectionConfig<RecordType>,
  rowSelection?: TableRowSelection<RecordType>,
): readonly [TransformColumns<RecordType>, Set<Key>] => {
  const {
      Severity: Minor
      Found in components/table/hooks/useSelection.tsx - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File useSelection.tsx has 606 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import * as React from 'react';
import { useCallback, useMemo } from 'react';
import DownOutlined from '@ant-design/icons/DownOutlined';
import classNames from 'classnames';
import { INTERNAL_COL_DEFINE } from 'rc-table';
      Severity: Major
      Found in components/table/hooks/useSelection.tsx - About 1 day to fix

        Function mergedSelections has 75 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const mergedSelections = useMemo<SelectionItem[] | null>(() => {
    if (!selections || hideSelectAll) {
      return null;
    }
        Severity: Major
        Found in components/table/hooks/useSelection.tsx - About 3 hrs to fix

          Consider simplifying this complex logical expression.
          Open

                if (selectionType !== 'radio') {
        let customizeSelections: React.ReactNode;
        if (mergedSelections) {
          const menu = {
            getPopupContainer,
          Severity: Critical
          Found in components/table/hooks/useSelection.tsx - About 2 hrs to fix

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

              const {
    prefixCls,
    data,
    pageData,
    getRecordByKey,
            Severity: Major
            Found in components/table/hooks/useSelection.tsx and 11 other locations - About 55 mins to fix
            components/affix/index.tsx on lines 60..70
            components/breadcrumb/Breadcrumb.tsx on lines 139..149
            components/float-button/style/index.ts on lines 95..105
            components/modal/style/confirm.ts on lines 13..23
            components/notification/useNotification.tsx on lines 58..68
            components/result/style/index.ts on lines 42..52
            components/slider/style/index.ts on lines 112..122
            components/steps/style/progress.ts on lines 8..18
            components/transfer/ListBody.tsx on lines 42..52
            components/transfer/ListItem.tsx on lines 24..34
            components/typography/Base/CopyBtn.tsx on lines 23..33

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status