ant-design/ant-design

View on GitHub
components/upload/Upload.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function InternalUpload has 352 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const InternalUpload: React.ForwardRefRenderFunction<UploadRef, UploadProps> = (props, ref) => {
  const {
    fileList,
    defaultFileList,
    onRemove,
Severity: Major
Found in components/upload/Upload.tsx - About 1 day to fix

    Function InternalUpload has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Open

    const InternalUpload: React.ForwardRefRenderFunction<UploadRef, UploadProps> = (props, ref) => {
      const {
        fileList,
        defaultFileList,
        onRemove,
    Severity: Minor
    Found in components/upload/Upload.tsx - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Upload.tsx has 391 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as React from 'react';
    import { flushSync } from 'react-dom';
    import classNames from 'classnames';
    import type { UploadProps as RcUploadProps } from 'rc-upload';
    import RcUpload from 'rc-upload';
    Severity: Minor
    Found in components/upload/Upload.tsx - About 5 hrs to fix

      Function onBatchStart has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const onBatchStart: RcUploadProps['onBatchStart'] = (batchFileInfoList) => {
          // Skip file which marked as `LIST_IGNORE`, these file will not add to file list
          const filteredFileInfoList = batchFileInfoList.filter(
            (info) => !(info.file as any)[LIST_IGNORE],
          );
      Severity: Minor
      Found in components/upload/Upload.tsx - About 1 hr to fix

        Function renderUploadList has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const renderUploadList = (button?: React.ReactNode, buttonVisible?: boolean) => {
            if (!showUploadList) {
              return button;
            }
            return (
        Severity: Minor
        Found in components/upload/Upload.tsx - About 1 hr to fix

          Function onInternalChange has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const onInternalChange = (
              file: UploadFile,
              changedFileList: UploadFile[],
              event?: { percent: number },
            ) => {
          Severity: Minor
          Found in components/upload/Upload.tsx - About 1 hr to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                {
                  [`${prefixCls}-rtl`]: direction === 'rtl',
                  [`${prefixCls}-picture-card-wrapper`]: listType === 'picture-card',
                  [`${prefixCls}-picture-circle-wrapper`]: listType === 'picture-circle',
                },
            Severity: Major
            Found in components/upload/Upload.tsx and 3 other locations - About 1 hr to fix
            components/input-number/index.tsx on lines 167..171
            components/input/OTP/index.tsx on lines 224..228
            components/skeleton/Element.tsx on lines 22..26

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status