Sign upLogin

antaresproject/core

View on GitHub
Star

Showing 306 of 306 total issues

Function uniqueMessages has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function uniqueMessages($messageBag, $messageBagFromCustom = null)
    {
        if (is_null($messageBagFromCustom)) {
            return $messageBag;
        }
Severity: Minor
Found in src/components/html/src/Validation/Validator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update(Listener $listener, array $input)
    {
        $input      = new Fluent($input);
        $driver     = $this->getValue($input['email_driver'], 'mail.driver');
        $validation = $this->validator->on($driver)->with($input->toArray());
Severity: Minor
Found in src/foundation/src/Processor/Mail.php - About 1 hr to fix

    Method render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function render($object = false)
    {
        $output = array_merge([
            'draw'            => (int) $this->request['draw'],
            'recordsTotal'    => $this->totalRecords,
    Severity: Minor
    Found in src/ui/components/datatables/src/Engines/BaseEngine.php - About 1 hr to fix

      Method down has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function down()
    {
        $orderToClear = [
            'tbl_notifications_stack_read',
            'tbl_notifications_stack_params',
      Severity: Minor
      Found in src/components/auth/resources/database/migrations/2017_07_24_082030_create_notifications_table.php - About 1 hr to fix

        Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run(OperationHandlerContract $handler, ExtensionContract $extension, array $flags = [])
    {
        try {
            $name = $extension->getPackage()->getName();
        Severity: Minor
        Found in src/components/extension/src/Processors/Installer.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          <?php

/**
 * Part of the Antares package.
 *
          Severity: Major
          Found in src/components/publisher/src/Publishing/ConfigPublisher.php and 1 other location - About 1 hr to fix
          src/components/publisher/src/Publishing/ViewPublisher.php on lines 1..54

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          <?php

/**
 * Part of the Antares package.
 *
          Severity: Major
          Found in src/components/publisher/src/Publishing/ViewPublisher.php and 1 other location - About 1 hr to fix
          src/components/publisher/src/Publishing/ConfigPublisher.php on lines 1..54

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method joinEagerLoadedColumn has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function joinEagerLoadedColumn($relation, $relationColumn)
    {
        $joins = [];
        foreach ((array) $this->getQueryBuilder()->joins as $key => $join) {
            $joins[] = $join->table;
          Severity: Minor
          Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

            Method ordering has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function ordering()
    {
        if ($this->orderCallback) {
            call_user_func($this->orderCallback, $this->getQueryBuilder());
            Severity: Minor
            Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

              Method middleware has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function middleware($middleware, array $options = [])
    {
        if (!isset($options['only']) or ! app('antares.installed')) {
            return $this->runMiddleware($middleware, $options);
        }
              Severity: Minor
              Found in src/foundation/src/Http/Controllers/AdminController.php - About 1 hr to fix

                Method getCustomfields has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function getCustomfields()
    {
        $extensions = extensions();
        $return     = [];
        event('customfields.before.search', $return);
                Severity: Minor
                Found in src/components/html/src/CustomfieldsFinder.php - About 1 hr to fix

                  Method resolveFields has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function resolveFields(Collection $fieldsets, $key = null)
    {
        $name          = $fieldsets->first()->name;
        $name instanceof \Closure and $name          = sprintf('fieldset-%d', $fieldsets->count());
        $formName      = str_slug($name);
                  Severity: Minor
                  Found in src/components/html/src/Adapter/FieldPermissionAdapter.php - About 1 hr to fix

                    Method build has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function build(Grid &$grid)
    {
        $attributes = array_merge($this->attributes, $grid->ajaxable);
        $inputs     = [];
        $fieldsets  = $grid->fieldsets();
                    Severity: Minor
                    Found in src/components/html/src/Builder/AjaxValidation.php - About 1 hr to fix

                      Method resolveFieldValue has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function resolveFieldValue($name, $row, Fluent $control)
    {
        if (ends_with($name, '[]')) {
            $fieldnameInRequest = str_replace('[]', '', $name);
            $oldRequest         = $this->request->old($fieldnameInRequest);
                      Severity: Minor
                      Found in src/components/html/src/Form/Control.php - About 1 hr to fix

                        Method verify has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function verify(array $items = [], $brandId = null)
    {

        $items   = $this->clear($items);
        $changed = [];
                        Severity: Minor
                        Found in src/components/memory/src/Component/ComponentHandler.php - About 1 hr to fix

                          Method up has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function up()
    {
        $this->down();

        /**
                          Severity: Minor
                          Found in src/components/memory/resources/database/migrations/2015_08_15_152342_create_tbl_country_table.php - About 1 hr to fix

                            Function setEngineInstance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function setEngineInstance(&$engine)
    {
        $filters = array_get($engine->getColumnDef(), 'filter', []);
        $values  = $this->getSessionValue();
        if (!$values) {
                            Severity: Minor
                            Found in src/ui/components/datatables/src/Adapter/GroupsFilterAdapter.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function add has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function add($name, $source, $dependencies = [], $attributes = [], $replaces = [])
    {
        if (!is_null($from      = array_get($attributes, 'from')) && !is_null($extension = extensions($from))) {
            $extensions = app('antares.extension')->getAvailableExtensions();
            $path       = null;
                            Severity: Minor
                            Found in src/utils/asset/src/Asset.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function publishAndPropagate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function publishAndPropagate(array $files = array(), $extension = null, $before = [])
    {
        $container = $this->assetFactory->container($this->position);
        if (empty($files)) {
            return $container;
                            Severity: Minor
                            Found in src/utils/asset/src/AssetPublisher.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function build has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function build(Grid &$grid)
    {
        $attributes = array_merge($this->attributes, $grid->ajaxable);
        $inputs     = [];
        $fieldsets  = $grid->fieldsets();
                            Severity: Minor
                            Found in src/components/html/src/Builder/AjaxValidation.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language