Sign upLogin

antaresproject/core

View on GitHub
Star
src/ui/components/datatables/src/Engines/QueryBuilderEngine.php

Summary

Maintainability
D
2 days
Test Coverage

File QueryBuilderEngine.php has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Part of the Antares package.
 *
Severity: Minor
Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 3 hrs to fix

    Function columnSearch has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function columnSearch()
    {
        $columns = $this->request->get('columns', []);

        foreach ($columns as $index => $column) {
    Severity: Minor
    Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    QueryBuilderEngine has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class QueryBuilderEngine extends BaseEngine
{

    /**
     * @param \Illuminate\Database\Query\Builder $builder
    Severity: Minor
    Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 2 hrs to fix

      Method filtering has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function filtering()
    {
        $this->query->where(
                function ($query) {
            $globalKeyword = $this->setupKeyword($this->request->keyword());
      Severity: Minor
      Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

        Function ordering has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function ordering()
    {
        if ($this->orderCallback) {
            call_user_func($this->orderCallback, $this->getQueryBuilder());
        Severity: Minor
        Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method columnSearch has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function columnSearch()
    {
        $columns = $this->request->get('columns', []);

        foreach ($columns as $index => $column) {
        Severity: Minor
        Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

          Method joinEagerLoadedColumn has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function joinEagerLoadedColumn($relation, $relationColumn)
    {
        $joins = [];
        foreach ((array) $this->getQueryBuilder()->joins as $key => $join) {
            $joins[] = $join->table;
          Severity: Minor
          Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

            Method ordering has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function ordering()
    {
        if ($this->orderCallback) {
            call_user_func($this->orderCallback, $this->getQueryBuilder());
            Severity: Minor
            Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 1 hr to fix

              Function joinEagerLoadedColumn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function joinEagerLoadedColumn($relation, $relationColumn)
    {
        $joins = [];
        foreach ((array) $this->getQueryBuilder()->joins as $key => $join) {
            $joins[] = $join->table;
              Severity: Minor
              Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method compileColumnQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  protected function compileColumnQuery($query, $method, $parameters, $column, $keyword)
              Severity: Minor
              Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 35 mins to fix

                Function compileColumnQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function compileColumnQuery($query, $method, $parameters, $column, $keyword)
    {
        if (method_exists($query, $method) && count($parameters) <= with(new \ReflectionMethod($query, $method))->getNumberOfParameters()
        ) {
            if (Str::contains(Str::lower($method), 'raw') || Str::contains(Str::lower($method), 'exists')
                Severity: Minor
                Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (count(explode('.', $column)) > 1) {
                    $eagerLoads     = $this->getEagerLoads();
                    $parts          = explode('.', $column);
                    $relationColumn = array_pop($parts);
                    $relation       = implode('.', $parts);
                Severity: Major
                Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php and 1 other location - About 1 hr to fix
                src/ui/components/datatables/src/Engines/QueryBuilderEngine.php on lines 329..337

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 115.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (count(explode('.', $column)) > 1) {
                    $eagerLoads     = $this->getEagerLoads();
                    $parts          = explode('.', $column);
                    $relationColumn = array_pop($parts);
                    $relation       = implode('.', $parts);
                Severity: Major
                Found in src/ui/components/datatables/src/Engines/QueryBuilderEngine.php and 1 other location - About 1 hr to fix
                src/ui/components/datatables/src/Engines/QueryBuilderEngine.php on lines 437..446

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 115.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status