Sign upLogin

antifuchs/gmail-britta

View on GitHub
Star

Showing 3 of 3 total issues

Method emit_filter_spec has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def self.emit_filter_spec(filter, infix=' ', recursive=false)
      case filter
      when String
        if recursive && filter =~ /\s/
          # filters can be parts of OR groups, which means whitespace
Severity: Minor
Found in lib/gmail-britta/filter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method emit_filter_spec has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.emit_filter_spec(filter, infix=' ', recursive=false)
      case filter
      when String
        if recursive && filter =~ /\s/
          # filters can be parts of OR groups, which means whitespace
Severity: Minor
Found in lib/gmail-britta/filter.rb - About 1 hr to fix

    Method single_write_accessor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def single_write_accessor(name, gmail_name, &block)
        direct_single_write_accessors[name] = gmail_name
        ivar = ivar_name(name)
        define_method(name) do |words|
          if instance_variable_get(ivar) and instance_variable_get(ivar) != []
    Severity: Minor
    Found in lib/gmail-britta/single_write_accessors.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language