src/Connection/CurlHttpClientAdapter.php
Method sendRequest
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function sendRequest($method, $url, $params = null)
{
$curl = curl_init();
curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
curl_setopt($curl, CURLOPT_USERAGENT, 'amoCRM-API-client/1.0');
Function sendRequest
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public function sendRequest($method, $url, $params = null)
{
$curl = curl_init();
curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
curl_setopt($curl, CURLOPT_USERAGENT, 'amoCRM-API-client/1.0');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '29', column '27'). Open
Open
throw new \LogicException('Unexpected method');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '54', column '23'). Open
Open
throw new \RuntimeException($curlError, $code);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Reference to undeclared constant \amocrm\Connection\CurlHttpClientAdapter::METHOD_GET
Open
Open
case self::METHOD_GET:
- Exclude checks
Unreachable statement detected Open
Open
break;
- Exclude checks
Possibly zero references to class \amocrm\Connection\CurlHttpClientAdapter
Open
Open
class CurlHttpClientAdapter implements HttpClientInterface
- Exclude checks
Reference to undeclared constant \amocrm\Connection\CurlHttpClientAdapter::METHOD_POST
Open
Open
case self::METHOD_POST:
- Exclude checks
Expected 1 newline at end of file; 0 found Open
Open
}
- Exclude checks