Sign upLogin

anyone-oslo/pages

View on GitHub
Star
app/javascript/components/PageTree/Node.tsx

Summary

Maintainability
D
2 days
Test Coverage

File Node.tsx has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
   Based on react-ui-tree
   https://github.com/pqx/react-ui-tree

   The MIT License (MIT)
Severity: Minor
Found in app/javascript/components/PageTree/Node.tsx - About 4 hrs to fix

    Function actions has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      actions() {
    const statusLabel = this.node().status != 2 ? "Publish" : "Hide";
    const statusIcon = this.node().status != 2 ? "check" : "ban";

    if (this.node().editing) {
    Severity: Minor
    Found in app/javascript/components/PageTree/Node.tsx - About 1 hr to fix

      Function renderEditNode has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        renderEditNode() {
    const { dir, locale } = this.props;

    const handleNameChange = (event: ChangeEvent<HTMLInputElement>) => {
      this.setState({ newName: event.target.value });
      Severity: Minor
      Found in app/javascript/components/PageTree/Node.tsx - About 1 hr to fix

        Function childNodes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          childNodes() {
    const { index, tree, dragging, dir, locale } = this.props;

    if (index.children && index.children.length && !index.node.collapsed) {
      const childrenStyles: CSSProperties = {};
        Severity: Minor
        Found in app/javascript/components/PageTree/Node.tsx - About 1 hr to fix

          Function render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render() {
    const props = this.props;
    const index = props.index;
    const dragging = props.dragging;
    const editing = this.node().editing;
          Severity: Minor
          Found in app/javascript/components/PageTree/Node.tsx - About 1 hr to fix

            Function collapseArrow has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              collapseArrow() {
    const index = this.props.index;

    // Don't collapse the root node
    if (!index.parent) {
            Severity: Minor
            Found in app/javascript/components/PageTree/Node.tsx - About 1 hr to fix

              Function renderNode has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                renderNode() {
    const index = this.props.index;
    const node = index.node;

    let pageName = <span className="name">{this.pageName()}</span>;
              Severity: Minor
              Found in app/javascript/components/PageTree/Node.tsx - About 1 hr to fix

                Function render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  render() {
    const props = this.props;
    const index = props.index;
    const dragging = props.dragging;
    const editing = this.node().editing;
                Severity: Minor
                Found in app/javascript/components/PageTree/Node.tsx - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function collapseArrow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  collapseArrow() {
    const index = this.props.index;

    // Don't collapse the root node
    if (!index.parent) {
                Severity: Minor
                Found in app/javascript/components/PageTree/Node.tsx - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function actions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  actions() {
    const statusLabel = this.node().status != 2 ? "Publish" : "Hide";
    const statusIcon = this.node().status != 2 ? "check" : "ban";

    if (this.node().editing) {
                Severity: Minor
                Found in app/javascript/components/PageTree/Node.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          {this.permitted("edit") &&
            this.button("Rename", {
              className: "edit",
              icon: "pencil",
              onClick: () => this.edit()
                Severity: Minor
                Found in app/javascript/components/PageTree/Node.tsx and 1 other location - About 45 mins to fix
                app/javascript/components/PageTree/Node.tsx on lines 117..122

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          {this.permitted("edit") &&
            this.button("Delete", {
              className: "delete",
              icon: "trash",
              onClick: () => this.deletePage()
                Severity: Minor
                Found in app/javascript/components/PageTree/Node.tsx and 1 other location - About 45 mins to fix
                app/javascript/components/PageTree/Node.tsx on lines 110..115

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status