Sign upLogin

ap2020/ap2020bot

View on GitHub
Star

Showing 11 of 11 total issues

Function verify has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const verify = async (req: APIGatewayProxyEventV2): Promise<boolean> => {
  const version = 'v0';
  const headers = CaseInsensitiveMap.fromObject(req.headers);

  const actual = headers.get('X-Slack-Signature');
Severity: Minor
Found in aws/src/lib/slack/verify.ts - About 1 hr to fix

    Function send has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const send = async ([sentChannel, channelId]: readonly [SentChannel, string]) => {
    const sentItems = items.filter(({ sentChannel: c }) => c === sentChannel);
    if (sentItems.length === 0) {
      return;
    }
    Severity: Minor
    Found in aws/src/watch-drive/notify-to-slack.ts - About 1 hr to fix

      Function getPath has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      export const getPath = async (client: drive_v3.Drive, item: DriveItem): Promise<string> => {
  /**
     * path: path to item
     * valid: true if path has rootFolderId in ancestor
     */
      Severity: Minor
      Found in aws/src/watch-drive/drive-api.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const colors = {
  create: '#6dc651',
  edit: '#f5bc41',
  move: '#1f28c6',
  rename: '#7337d3',
      Severity: Minor
      Found in aws/src/watch-drive/config.ts and 1 other location - About 50 mins to fix
      aws/src/watch-drive/config.ts on lines 27..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const japaneseTranslations = {
  create: '追加',
  edit: '更新',
  move: '移動',
  rename: '名称変更',
      Severity: Minor
      Found in aws/src/watch-drive/config.ts and 1 other location - About 50 mins to fix
      aws/src/watch-drive/config.ts on lines 16..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function notifyToSlack has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export const notifyToSlack = async ({ slack, drive, people: peopleAPI }: Clients, activity: driveactivity_v2.Schema$DriveActivity, groupEmailAddress: string) => {
  // not notified in order!
  // maybe chat.scheduleMessage is useful to imitate notification in order
  // but I think the inorderness is ignorable if the frequency of execution is high enough
  const actionName = getActionName(activity.primaryActionDetail!);
      Severity: Minor
      Found in aws/src/watch-drive/notify-to-slack.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getDriveItem has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export const getDriveItem = async (drive: drive_v3.Drive, target: driveactivity_v2.Schema$Target): Promise<DriveItem> => {
  if (!target.driveItem) {
    throw new Error(`Not driveItem: ${target}`);
  }
  try {
      Severity: Minor
      Found in aws/src/watch-drive/drive-activity-api.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function verify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export const verify = async (req: APIGatewayProxyEventV2): Promise<boolean> => {
  const version = 'v0';
  const headers = CaseInsensitiveMap.fromObject(req.headers);

  const actual = headers.get('X-Slack-Signature');
      Severity: Minor
      Found in aws/src/lib/slack/verify.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return 'none';
      Severity: Major
      Found in aws/src/watch-drive/drive-api.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in aws/src/lib/slack/verify.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return ok;
          Severity: Major
          Found in aws/src/lib/slack/verify.ts - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language