Showing 9 of 11 total issues
Function verify
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const verify = async (req: APIGatewayProxyEventV2): Promise<boolean> => {
const version = 'v0';
const headers = CaseInsensitiveMap.fromObject(req.headers);
const actual = headers.get('X-Slack-Signature');
Function send
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
const send = async ([sentChannel, channelId]: readonly [SentChannel, string]) => {
const sentItems = items.filter(({ sentChannel: c }) => c === sentChannel);
if (sentItems.length === 0) {
return;
}
Function getPath
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
export const getPath = async (client: drive_v3.Drive, item: DriveItem): Promise<string> => {
/**
* path: path to item
* valid: true if path has rootFolderId in ancestor
*/
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function notifyToSlack
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
export const notifyToSlack = async ({ slack, drive, people: peopleAPI }: Clients, activity: driveactivity_v2.Schema$DriveActivity, groupEmailAddress: string) => {
// not notified in order!
// maybe chat.scheduleMessage is useful to imitate notification in order
// but I think the inorderness is ignorable if the frequency of execution is high enough
const actionName = getActionName(activity.primaryActionDetail!);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getDriveItem
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
export const getDriveItem = async (drive: drive_v3.Drive, target: driveactivity_v2.Schema$Target): Promise<DriveItem> => {
if (!target.driveItem) {
throw new Error(`Not driveItem: ${target}`);
}
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function verify
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
export const verify = async (req: APIGatewayProxyEventV2): Promise<boolean> => {
const version = 'v0';
const headers = CaseInsensitiveMap.fromObject(req.headers);
const actual = headers.get('X-Slack-Signature');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return 'none';
Avoid too many return
statements within this function. Open
return false;
Avoid too many return
statements within this function. Open
return ok;