apel/common/hashing.py

Summary

Maintainability
A
0 mins
Test Coverage

At least two spaces before inline comment
Open

    except IOError: # not a gzipped file
Severity: Minor
Found in apel/common/hashing.py by pep8

Separate inline comments by at least two spaces.

An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

Line too long (80 > 79 characters)
Open

    Calculates MD5 hash from content of file with name='fname'.  Also opens gzip
Severity: Minor
Found in apel/common/hashing.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Expected 2 blank lines, found 1
Open

def calculate_hash(fname):
Severity: Minor
Found in apel/common/hashing.py by pep8

Separate top-level function and class definitions with two blank lines.

Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

Variable name fp doesn't conform to snake_case naming style
Open

        fp = gzip.open(fname, 'rb')
Severity: Info
Found in apel/common/hashing.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

Variable name fp doesn't conform to snake_case naming style
Open

        fp = open(fname, 'rb')
Severity: Info
Found in apel/common/hashing.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

Variable name md doesn't conform to snake_case naming style
Open

    md = md5()
Severity: Info
Found in apel/common/hashing.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

There are no issues that match your filters.

Category
Status