Sign upLogin

apimatic/core-lib-php

View on GitHub
Star

Showing 27 of 32 total issues

Avoid too many return statements within this method.
Open

        return $success;
Severity: Major
Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $value;
    Severity: Major
    Found in src/Request/Parameters/EncodedParam.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return implode($separatorFormat ? '' : '&', $result);
      Severity: Major
      Found in src/Request/Parameters/EncodedParam.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return !$this->checkValues || $this->isListProperSubsetOf($expected, $actual);
        Severity: Major
        Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return;
          Severity: Major
          Found in src/Request/Parameters/EncodedParam.php - About 30 mins to fix

            Function getResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getResult(Context $context)
    {
        $statusCode = $context->getResponse()->getStatusCode();
        if ($this->shouldReturnNull($statusCode)) {
            if ($this->useApiResponse) {
            Severity: Minor
            Found in src/Response/ResponseError.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addContentType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function addContentType(string $format): void
    {
        if (!$this->allowContentType) {
            return;
        }
            Severity: Minor
            Found in src/Request/Request.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language