Showing 27 of 32 total issues
DateHelper
has 36 functions (exceeds 20 allowed). Consider refactoring. Open
class DateHelper
{
/**
* Match the pattern for a datetime string in simple date format
*/
File DateHelper.php
has 304 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
namespace Core\Utils;
Request
has 23 functions (exceeds 20 allowed). Consider refactoring. Open
class Request implements RequestSetterInterface
{
private $converter;
private $queryUrl;
private $requestMethod = RequestMethod::GET;
Method compare
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function compare($expected, $actual): bool
{
$bothNull = $this->checkForNull($expected, $actual);
if (isset($bothNull)) {
return !$this->checkValues || $bothNull;
Method httpBuildQuery
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function httpBuildQuery(array $data, string $format, string $parent = ''): string
{
if ($format == RequestArraySerialization::INDEXED) {
return http_build_query($data);
}
Function compare
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function compare($expected, $actual): bool
{
$bothNull = $this->checkForNull($expected, $actual);
if (isset($bothNull)) {
return !$this->checkValues || $bothNull;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
HttpClientInterface $httpClient,
ConverterInterface $converter,
JsonHelper $jsonHelper,
array $authManagers,
array $serverUrls,
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct($request, ?int $statusCode, ?string $reasonPhrase, ?array $headers, $result, $body)
Function intersectArrays
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private function intersectArrays(array $leftList, array $rightList): array
{
$commonList = [];
foreach ($leftList as $leftVal) {
foreach ($rightList as $rightVal) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getChildNodeByTagName
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private static function getChildNodeByTagName(\DOMNode $node, string $name): ?\DOMElement
{
if ($node->hasChildNodes()) {
foreach ($node->childNodes as $childNode) {
if ($childNode->nodeType === XML_ELEMENT_NODE && $childNode->tagName === $name) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getChildNodesByTagName
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private static function getChildNodesByTagName(\DOMNode $node, string $name): array
{
$arr = [];
if ($node->hasChildNodes()) {
foreach ($node->childNodes as $childNode) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function apply
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function apply(RequestSetterInterface $request): void
{
if (!$this->validated) {
return;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return;
Avoid too many return
statements within this method. Open
return $value;
Avoid too many return
statements within this method. Open
return;
Avoid too many return
statements within this method. Open
return;
Avoid too many return
statements within this method. Open
return !$this->checkValues;
Avoid too many return
statements within this method. Open
return $success;
Avoid too many return
statements within this method. Open
return;
Avoid too many return
statements within this method. Open
return;