apimatic/core-lib-php

View on GitHub

Showing 26 of 31 total issues

DateHelper has 36 functions (exceeds 20 allowed). Consider refactoring.
Open

class DateHelper
{
    /**
     * Match the pattern for a datetime string in simple date format
     */
Severity: Minor
Found in src/Utils/DateHelper.php - About 4 hrs to fix

    File DateHelper.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    namespace Core\Utils;
    Severity: Minor
    Found in src/Utils/DateHelper.php - About 3 hrs to fix

      Request has 23 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Request implements RequestSetterInterface
      {
          private $converter;
          private $queryUrl;
          private $requestMethod = RequestMethod::GET;
      Severity: Minor
      Found in src/Request/Request.php - About 2 hrs to fix

        Method compare has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function compare($expected, $actual): bool
            {
                $bothNull = $this->checkForNull($expected, $actual);
                if (isset($bothNull)) {
                    return !$this->checkValues || $bothNull;
        Severity: Major
        Found in src/TestCase/BodyMatchers/BodyComparator.php - About 2 hrs to fix

          Method httpBuildQuery has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function httpBuildQuery(array $data, string $format, string $parent = ''): string
              {
                  if ($format == RequestArraySerialization::INDEXED) {
                      return http_build_query($data);
                  }
          Severity: Minor
          Found in src/Request/Parameters/EncodedParam.php - About 1 hr to fix

            Function compare has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function compare($expected, $actual): bool
                {
                    $bothNull = $this->checkForNull($expected, $actual);
                    if (isset($bothNull)) {
                        return !$this->checkValues || $bothNull;
            Severity: Minor
            Found in src/TestCase/BodyMatchers/BodyComparator.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    HttpClientInterface $httpClient,
                    ConverterInterface $converter,
                    JsonHelper $jsonHelper,
                    array $authManagers,
                    array $serverUrls,
            Severity: Major
            Found in src/Client.php - About 1 hr to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function __construct($request, ?int $statusCode, ?string $reasonPhrase, ?array $headers, $result, $body)
              Severity: Minor
              Found in src/Types/Sdk/CoreApiResponse.php - About 45 mins to fix

                Function getChildNodesByTagName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private static function getChildNodesByTagName(\DOMNode $node, string $name): array
                    {
                        $arr = [];
                        if ($node->hasChildNodes()) {
                            foreach ($node->childNodes as $childNode) {
                Severity: Minor
                Found in src/Utils/XmlDeserializer.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function apply has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function apply(RequestSetterInterface $request): void
                    {
                        if (!$this->validated) {
                            return;
                        }
                Severity: Minor
                Found in src/Request/Parameters/FormParam.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getChildNodeByTagName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private static function getChildNodeByTagName(\DOMNode $node, string $name): ?\DOMElement
                    {
                        if ($node->hasChildNodes()) {
                            foreach ($node->childNodes as $childNode) {
                                if ($childNode->nodeType === XML_ELEMENT_NODE && $childNode->tagName === $name) {
                Severity: Minor
                Found in src/Utils/XmlDeserializer.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function intersectArrays has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function intersectArrays(array $leftList, array $rightList): array
                    {
                        $commonList = [];
                        foreach ($leftList as $leftVal) {
                            foreach ($rightList as $rightVal) {
                Severity: Minor
                Found in src/TestCase/BodyMatchers/BodyComparator.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                                return;
                Severity: Major
                Found in src/Request/Parameters/EncodedParam.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in src/Request/Request.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return;
                    Severity: Major
                    Found in src/Request/Request.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return !$this->checkValues || $this->isListProperSubsetOf($expected, $actual);
                      Severity: Major
                      Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return implode($separatorFormat ? '' : '&', $result);
                        Severity: Major
                        Found in src/Request/Parameters/EncodedParam.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return $this->getEncodedReplacer($value);
                          Severity: Major
                          Found in src/Request/Parameters/TemplateParam.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return;
                            Severity: Major
                            Found in src/Request/Parameters/EncodedParam.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return !$this->checkValues;
                              Severity: Major
                              Found in src/TestCase/BodyMatchers/BodyComparator.php - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language