Sign upLogin

aporia-ai/kubesurvival

View on GitHub
Star

Showing 5 of 5 total issues

Function main has 79 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    // Read argument
    if len(os.Args) != 2 {
        fmt.Println("USAGE: ./kubesurvival <YAML_CONFIG_PATH>")
        os.Exit(1)
Severity: Major
Found in main.go - About 2 hrs to fix

    Function main has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func main() {
    // Read argument
    if len(os.Args) != 2 {
        fmt.Println("USAGE: ./kubesurvival <YAML_CONFIG_PATH>")
        os.Exit(1)
    Severity: Minor
    Found in main.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has 7 return statements (exceeds 4 allowed).
    Open

    func main() {
    // Read argument
    if len(os.Args) != 2 {
        fmt.Println("USAGE: ./kubesurvival <YAML_CONFIG_PATH>")
        os.Exit(1)
    Severity: Major
    Found in main.go - About 45 mins to fix

      Method AWSNodeSource.GetNodes has 5 return statements (exceeds 4 allowed).
      Open

      func (s *AWSNodeSource) GetNodes() ([]*AWSNode, error) {
    instances, err := ec2instancesinfo.Data()
    if err != nil {
        return nil, errors.Wrap(err, "could not get ec2 instances info")
    }
      Severity: Major
      Found in pkg/nodesource/aws.go - About 35 mins to fix

        Method AWSNodeSource.getMaxPodsPerInstance has 5 return statements (exceeds 4 allowed).
        Open

        func (s *AWSNodeSource) getMaxPodsPerInstance() (map[string]int, error) {
    response, err := http.Get("https://raw.githubusercontent.com/awslabs/amazon-eks-ami/master/files/eni-max-pods.txt")
    if err != nil {
        return nil, errors.Wrap(err, "could not fetch max pods list")
    }
        Severity: Major
        Found in pkg/nodesource/aws.go - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language