Sign upLogin

apparat/object

View on GitHub
Star

Showing 170 of 170 total issues

Function processDocument has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function processDocument(Document $document)
    {
        $walker = $document->walker();
        while ($event = $walker->next()) {
            $node = $event->getNode();
Severity: Minor
Found in src/Object/Infrastructure/Utilities/CommonMarkPayloadProcessor.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(array $data, ObjectInterface $object)
    {
        parent::__construct($data, $object);

        // Run through all registered relation type collections
Severity: Minor
Found in src/Object/Domain/Model/Properties/Relations.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function composeFullName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function composeFullName($propertyName, $propertyValue)
    {
        $nameProperties = [
            Contact::HONORIFIC_PREFIX => '',
            Contact::GIVEN_NAME => '',
Severity: Minor
Found in src/Object/Application/Model/Properties/Domain/Traits/ContactPropertiesModelTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deleteRecursive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function deleteRecursive($directory)
    {
        $this->tmpFiles[] = $directory;
        foreach (scandir($directory) as $item) {
            if (!preg_match('%^\.+$%', $item)) {
Severity: Minor
Found in src/Object/Tests/AbstractObjectTest.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(array $data, ObjectInterface $object)
    {
        parent::__construct($data, $object);

        // Initialize the title
Severity: Minor
Found in src/Object/Domain/Model/Properties/MetaProperties.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($locator = null, $datePrecision = null, &$leader = '')
    {
        if (!empty($locator)) {
            // If the local default date precision should be used
            if ($datePrecision === null) {
Severity: Minor
Found in src/Object/Domain/Model/Uri/Locator.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method setDomainProperties has a boolean flag argument $overwrite, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function setDomainProperties(GenericPropertiesInterface $domainProperties, $overwrite = false)
Severity: Minor
Found in src/Object/Domain/Model/Object/Traits/DomainPropertiesTrait.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/Object/Domain/Model/Uri/ObjectUrl.php - About 30 mins to fix

    The method toUrl has a boolean flag argument $canonical, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function toUrl($canonical = false)
    Severity: Minor
    Found in src/Object/Domain/Model/Uri/ObjectUrl.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $draft, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($revision, $draft = false)
    Severity: Minor
    Found in src/Object/Domain/Model/Object/Revision.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Missing class import via use statement (line '59', column '26').
    Open

                $value = new \DateTimeImmutable($value);
    Severity: Minor
    Found in src/Object/Application/Model/Properties/Datatype/Datetime.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method toRepositoryUrl has a boolean flag argument $local, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function toRepositoryUrl($local = false, $canonical = false)
    Severity: Minor
    Found in src/Object/Domain/Model/Uri/RepositoryLocator.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Missing class import via use statement (line '98', column '22').
    Open

                || !(new \ReflectionClass($this->domainPropertyCClass))->isSubclassOf(AbstractDomainProperties::class)
    Severity: Minor
    Found in src/Object/Domain/Model/Object/AbstractObject.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in src/Object/Domain/Model/Uri/Url.php - About 30 mins to fix

      The method __construct has a boolean flag argument $remote, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($url, $remote = false, RepositoryInterface $contextRepository = null)
      Severity: Minor
      Found in src/Object/Domain/Model/Uri/ApparatUrl.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method __construct has a boolean flag argument $remote, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($url, $remote = false)
      Severity: Minor
      Found in src/Object/Domain/Model/Uri/ObjectUrl.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '71', column '23').
      Open

                  throw new \InvalidArgumentException;
      Severity: Minor
      Found in src/Object/Application/Model/Properties/Datatype/ApparatUrl.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method toRepositoryUrl has a boolean flag argument $canonical, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function toRepositoryUrl($local = false, $canonical = false)
      Severity: Minor
      Found in src/Object/Domain/Model/Uri/RepositoryLocator.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getPropertyData has a boolean flag argument $serialize, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getPropertyData($serialize = true);
      Severity: Minor
      Found in src/Object/Domain/Model/Object/ObjectInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '129', column '26').
      Open

                          (new \ReflectionClass($value))->implementsInterface(SerializablePropertyInterface::class)
      Severity: Minor
      Found in src/Object/Domain/Model/Properties/AbstractProperties.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Severity
      Category
      Status
      Source
      Language