apparat/object

View on GitHub
src/Object/Domain/Model/Properties/SystemProperties.php

Summary

Maintainability
B
6 hrs
Test Coverage

SystemProperties has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class SystemProperties extends AbstractProperties
{
    /**
     * Collection name
     *
Severity: Minor
Found in src/Object/Domain/Model/Properties/SystemProperties.php - About 2 hrs to fix

    Method __construct has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(array $data, ObjectInterface $object)
        {
            parent::__construct($data, $object);
    
            // Initialize the object ID
    Severity: Minor
    Found in src/Object/Domain/Model/Properties/SystemProperties.php - About 1 hr to fix

      Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct(array $data, ObjectInterface $object)
          {
              parent::__construct($data, $object);
      
              // Initialize the object ID
      Severity: Minor
      Found in src/Object/Domain/Model/Properties/SystemProperties.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

              if (!($this->uid instanceof Id)
                  || !($this->type instanceof Type)
                  || !($this->revision instanceof Revision)
                  || !($this->created instanceof \DateTimeInterface)
                  || !($this->modified instanceof \DateTimeInterface)
      Severity: Major
      Found in src/Object/Domain/Model/Properties/SystemProperties.php - About 40 mins to fix

        The method __construct() has an NPath complexity of 3584. The configured NPath complexity threshold is 200.
        Open

            public function __construct(array $data, ObjectInterface $object)
            {
                parent::__construct($data, $object);
        
                // Initialize the object ID

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method __construct() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
        Open

            public function __construct(array $data, ObjectInterface $object)
            {
                parent::__construct($data, $object);
        
                // Initialize the object ID

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Missing class import via use statement (line '478', column '43').
        Open

                $systemProperties->modified = new \DateTimeImmutable();

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '434', column '20').
        Open

                $now = new \DateTimeImmutable('now');

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        The method toArray has a boolean flag argument $serialize, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function toArray($serialize = true)

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Missing class import via use statement (line '465', column '44').
        Open

                $systemProperties->published = new \DateTimeImmutable();

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '490', column '42').
        Open

                $systemProperties->deleted = new \DateTimeImmutable();

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        There are no issues that match your filters.

        Category
        Status