apparat/object

View on GitHub
src/Object/Domain/Model/Uri/ObjectUrl.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function matches has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function matches(Url $url)
    {
        // If the standard URL components don't match
        if (!parent::matches($url)) {
            return false;
Severity: Minor
Found in src/Object/Domain/Model/Uri/ObjectUrl.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/Object/Domain/Model/Uri/ObjectUrl.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return false;
    Severity: Major
    Found in src/Object/Domain/Model/Uri/ObjectUrl.php - About 30 mins to fix

      The method toUrl has a boolean flag argument $canonical, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function toUrl($canonical = false)

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method __construct has a boolean flag argument $remote, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($url, $remote = false)

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      There are no issues that match your filters.

      Category
      Status