Sign upLogin

appbaseio/reactivesearch

View on GitHub
Star
packages/vue/src/components/basic/SelectedFilters.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function renderFilters has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        renderFilters() {
            const { selectedValues } = this;
            return Object.keys(selectedValues)
                .filter(
                    id => this.components.includes(id) && selectedValues[id].showFilter
Severity: Minor
Found in packages/vue/src/components/basic/SelectedFilters.jsx - About 1 hr to fix

    Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        if (this.$scopedSlots.default) {
            return this.$scopedSlots.default(this.$props);
        }
        const filtersToRender = this.renderFilters();
    Severity: Minor
    Found in packages/vue/src/components/basic/SelectedFilters.jsx - About 1 hr to fix

      Function renderValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              renderValue(value, isArray) {
            if (isArray && value.length) {
                const arrayToRender = value.map(item => this.renderValue(item));
                return arrayToRender.join(', ');
            }
      Severity: Minor
      Found in packages/vue/src/components/basic/SelectedFilters.jsx - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                          if (label && ((isArray && value.length) || (!isArray && value))) {
                        const valueToRender = this.renderValue(value, isArray);
                        return (
                            <Button
                                class={getClassName(this.$props.innerClass, 'button') || ''}
      Severity: Major
      Found in packages/vue/src/components/basic/SelectedFilters.jsx - About 40 mins to fix

        Function render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            render() {
        if (this.$scopedSlots.default) {
            return this.$scopedSlots.default(this.$props);
        }
        const filtersToRender = this.renderFilters();
        Severity: Minor
        Found in packages/vue/src/components/basic/SelectedFilters.jsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (value && typeof value === 'object') {
                // TODO: support for NestedList
                let label
                    = (typeof value.label === 'string' ? value.label : value.value)
                    || value.key
        Severity: Major
        Found in packages/vue/src/components/basic/SelectedFilters.jsx and 1 other location - About 3 hrs to fix
        packages/web/src/components/basic/SelectedFilters.js on lines 33..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status