appbaseio/reactivesearch

View on GitHub
packages/vue/src/components/range/SingleRange.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        return (
            <Container class={this.$props.className}>
                {this.$props.title && (
                    <Title class={getClassName(this.$props.innerClass, 'title')}>
Severity: Minor
Found in packages/vue/src/components/range/SingleRange.jsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        props: {
            beforeValueChange: types.func,
            className: VueTypes.string.def(''),
            componentId: types.stringRequired,
            customQuery: types.func,
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 1 other location - About 6 hrs to fix
    packages/vue/src/components/range/MultiRange.jsx on lines 24..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 164.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        watch: {
            react() {
                this.setReact(this.$props);
            },
            dataField() {
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 1 other location - About 4 hrs to fix
    packages/vue/src/components/range/MultiRange.jsx on lines 105..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            updateQueryHandler(value, props) {
                const query = props.customQuery || SingleRange.defaultQuery;
                this.updateQuery({
                    componentId: props.componentId,
                    query: query(value, props),
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 5 other locations - About 3 hrs to fix
    packages/vue/src/components/list/MultiDropdownList.jsx on lines 302..313
    packages/vue/src/components/list/MultiList.jsx on lines 333..344
    packages/vue/src/components/list/SingleDropdownList.jsx on lines 239..250
    packages/vue/src/components/list/SingleList.jsx on lines 280..291
    packages/vue/src/components/range/MultiRange.jsx on lines 91..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                                    <label
                                        class={getClassName(this.$props.innerClass, 'label')}
                                        for={`${this.$props.componentId}-${item.label}`}
                                    >
                                        {item.label}
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 1 other location - About 1 hr to fix
    packages/vue/src/components/range/MultiRange.jsx on lines 176..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    SingleRange.defaultQuery = (value, props) => {
        if (value) {
            return {
                range: {
                    [props.dataField]: {
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 1 other location - About 1 hr to fix
    packages/native/src/components/range/SingleDropdownRange.js on lines 69..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

        created() {
            const onQueryChange = (...args) => {
                this.$emit('queryChange', ...args);
            };
            this.setQueryListener(this.$props.componentId, onQueryChange, null);
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 6 other locations - About 1 hr to fix
    packages/vue/src/components/list/MultiDropdownList.jsx on lines 72..77
    packages/vue/src/components/list/MultiList.jsx on lines 69..74
    packages/vue/src/components/list/SingleDropdownList.jsx on lines 70..75
    packages/vue/src/components/list/SingleList.jsx on lines 67..72
    packages/vue/src/components/range/MultiRange.jsx on lines 122..127
    packages/vue/src/components/range/RangeSlider.jsx on lines 125..130

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                const performUpdate = () => {
                    this.currentValue = currentValue;
                    this.updateQueryHandler(currentValue, props);
                    this.locked = false;
                    this.$emit('valueChange', currentValue);
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 3 other locations - About 1 hr to fix
    packages/vue/src/components/list/MultiDropdownList.jsx on lines 287..292
    packages/vue/src/components/list/SingleDropdownList.jsx on lines 224..229
    packages/vue/src/components/list/SingleList.jsx on lines 265..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                    {this.$props.title && (
                        <Title class={getClassName(this.$props.innerClass, 'title')}>
                            {this.$props.title}
                        </Title>
                    )}
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 3 other locations - About 1 hr to fix
    packages/vue/src/components/list/MultiList.jsx on lines 149..153
    packages/vue/src/components/range/MultiRange.jsx on lines 146..150
    packages/vue/src/components/range/RangeSlider.jsx on lines 156..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    const mapStateToProps = (state, props) => ({
        selectedValue:
            (state.selectedValues[props.componentId]
                && state.selectedValues[props.componentId].value)
            || null,
    Severity: Major
    Found in packages/vue/src/components/range/SingleRange.jsx and 8 other locations - About 55 mins to fix
    packages/native/src/components/basic/DataController.js on lines 103..108
    packages/native/src/components/basic/TextField.js on lines 239..244
    packages/native/src/components/range/SingleDropdownRange.js on lines 184..189
    packages/vue/src/components/range/MultiRange.jsx on lines 223..228
    packages/web/src/components/basic/DataController.js on lines 112..117
    packages/web/src/components/basic/ToggleButton.js on lines 252..257
    packages/web/src/components/range/RatingsFilter.js on lines 218..223
    packages/web/src/components/range/SingleRange.js on lines 220..225

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status