Sign upLogin

appbaseio/reactivesearch

View on GitHub
Star
packages/vue/src/components/shared/DropDown.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 161 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {
            items,
            selectedItem,
            placeholder,
Severity: Major
Found in packages/vue/src/components/shared/DropDown.jsx - About 6 hrs to fix

    Function render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        render() {
        const {
            items,
            selectedItem,
            placeholder,
    Severity: Minor
    Found in packages/vue/src/components/shared/DropDown.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function renderToString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            renderToString(value) {
            if (Array.isArray(value) && value.length) {
                const arrayToRender = value.map(item => this.renderToString(item));
                return arrayToRender.join(', ');
            } else if (value && typeof value === 'object') {
    Severity: Minor
    Found in packages/vue/src/components/shared/DropDown.jsx - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getBackgroundColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            getBackgroundColor(highlighted, selected) {
            const isDark = this.$props.themePreset === 'dark';

            if (highlighted) {
                return isDark ? '#555' : '#eee';
    Severity: Minor
    Found in packages/vue/src/components/shared/DropDown.jsx - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return value;
    Severity: Major
    Found in packages/vue/src/components/shared/DropDown.jsx - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              renderToString(value) {
            if (Array.isArray(value) && value.length) {
                const arrayToRender = value.map(item => this.renderToString(item));
                return arrayToRender.join(', ');
            } else if (value && typeof value === 'object') {
      Severity: Major
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 6 hrs to fix
      packages/web/src/components/shared/Dropdown.js on lines 74..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 170.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                          {this.$props.showSearch ? (
                                        <Input
                                            id={`${this.$props.componentId}-input`}
                                            style={{
                                                border: 0,
      Severity: Major
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 4 hrs to fix
      packages/web/src/components/shared/Dropdown.js on lines 140..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

                                          {itemsToRender
                                        .filter(item => {
                                            if (String(item[labelField]).length) {
                                                if (this.$props.showSearch && this.$data.searchTerm) {
                                                    return String(item[labelField])
      Severity: Major
      Found in packages/vue/src/components/shared/DropDown.jsx and 5 other locations - About 3 hrs to fix
      packages/vue/src/components/list/MultiList.jsx on lines 183..240
      packages/vue/src/components/list/SingleList.jsx on lines 169..232
      packages/web/src/components/shared/Dropdown.js on lines 155..231
      packages/web/src/components/list/MultiList.js on lines 413..466
      packages/web/src/components/list/SingleList.js on lines 323..377

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                                  let selected
                                                = this.$props.multi // MultiDropdownList
                                                && ((selectedItem && !!selectedItem[item[keyField]]) // MultiDropdownRange
                                                    || (Array.isArray(selectedItem)
                                                        && selectedItem.find(
      Severity: Major
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 2 hrs to fix
      packages/web/src/components/shared/Dropdown.js on lines 168..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              getBackgroundColor(highlighted, selected) {
            const isDark = this.$props.themePreset === 'dark';

            if (highlighted) {
                return isDark ? '#555' : '#eee';
      Severity: Major
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 1 hr to fix
      packages/web/src/components/shared/Dropdown.js on lines 57..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (this.$props.returnsObject) {
                this.$props.handleChange(item);
            } else {
                this.$props.handleChange(item[this.$props.keyField]);
            }
      Severity: Major
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 1 hr to fix
      packages/web/src/components/shared/Dropdown.js on lines 35..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                  <Select
                                {...{
                                    on: {
                                        ...getButtonProps({
                                            onClick: this.toggle
      Severity: Minor
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 40 mins to fix
      packages/web/src/components/shared/Dropdown.js on lines 121..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const {
            items,
            selectedItem,
            placeholder,
            labelField,
      Severity: Minor
      Found in packages/vue/src/components/shared/DropDown.jsx and 1 other location - About 40 mins to fix
      packages/vue/src/components/result/ReactiveList.jsx on lines 10..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status