Sign upLogin

appdrones/page_record

View on GitHub
Star

Showing 6 of 6 total issues

Method semantic_form_for has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def semantic_form_for(record_or_name_or_array, *args, &proc)
        extend(PageRecord::Helpers)
        options = args.extract_options!
        options ||= {}
        case record_or_name_or_array
Severity: Minor
Found in lib/page_record/formtastic.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method attribute_tag_for has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def attribute_tag_for(name, attribute, content_or_options_with_block = nil, options = nil, escape = true, &block)
Severity: Minor
Found in lib/page_record/helpers.rb - About 45 mins to fix

    Method record_form_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def record_form_for(record, options = {}, &block)
      case record
      when String, Symbol
        object_name = record
      else
    Severity: Minor
    Found in lib/page_record/helpers.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          case record
      when String, Symbol
        object_name = record
      else
        object      = record.is_a?(Array) ? record.last : record
    Severity: Minor
    Found in lib/page_record/helpers.rb and 1 other location - About 25 mins to fix
    lib/page_record/formtastic.rb on lines 65..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            case record_or_name_or_array
        when String, Symbol
          object_name = record_or_name_or_array
        else
          object      = record_or_name_or_array.is_a?(Array) ? record_or_name_or_array.last : record_or_name_or_array
    Severity: Minor
    Found in lib/page_record/formtastic.rb and 1 other location - About 25 mins to fix
    lib/page_record/helpers.rb on lines 215..222

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method find_record has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def find_record(selector, filter)
      selector ||= @selector
      filter ||= @filter
      id_text = @id.blank? ? '' : "='#{@id}'"
      begin
    Severity: Minor
    Found in lib/page_record/base.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language