Sign upLogin

appfolio/gemsurance

View on GitHub
Star

Showing 5 of 5 total issues

Method add_vulnerability_data has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def add_vulnerability_data(vulnerabilities_directory = './tmp/vulnerabilities/gems')
      puts "Reading vulnerability data..."

      @gem_infos.each do |gem_info|
        vulnerability_directory = File.join(vulnerabilities_directory, gem_info.name)
Severity: Minor
Found in lib/gemsurance/runner.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def parse(*argv)

        options = {}

        opts = OptionParser.new do |opts|
Severity: Minor
Found in lib/gemsurance/cli.rb - About 1 hr to fix

    Method retrieve has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def retrieve(options = {})
      gem_infos = []

      @specs.each do |current_spec|
        active_spec = @bundle_definition.index[current_spec.name].sort_by { |b| b.version }
    Severity: Minor
    Found in lib/gemsurance/gem_info_retriever.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def initialize(name, current_version, newest_version, in_gem_file, homepage_uri, source_code_uri, documentation_uri, status = STATUS_CURRENT)
    Severity: Major
    Found in lib/gemsurance/gem_info_retriever.rb - About 1 hr to fix

      Method formatted_values has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def formatted_values
        GEM_ATTRIBUTES.map do |attr|
          if attr == :vulnerabilities
            if @vulnerabilities.empty?
              ''
      Severity: Minor
      Found in lib/gemsurance/gem_info_retriever.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language