Sign upLogin

appirio-tech/lc1-challenge-service

View on GitHub
Star

Showing 35 of 35 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (currentUserIsAdmin) {
      async.waterfall([
        function(cb) {
          findById(Challenge, {where: {id:challengeId}}, cb);
        },
Severity: Major
Found in api/controllers/storage.js and 1 other location - About 1 day to fix
api/controllers/storage.js on lines 144..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 224.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (currentUserIsAdmin) {
      async.waterfall([
          function(cb) {
            findById(Challenge, {where: {id:challengeId}}, cb);
          },
Severity: Major
Found in api/controllers/storage.js and 1 other location - About 1 day to fix
api/controllers/storage.js on lines 49..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 224.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {
  var databaseUrl;

  var re;
  var swagger;
Severity: Major
Found in Gruntfile.js - About 4 hrs to fix

    Function getSubmissionFileURL has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var getSubmissionFileURL = function(method, req, res, next) {
  var challengeId = req.swagger.params.challengeId.value;
  var submissionId = req.swagger.params.submissionId.value;
  var user = auth.getSigninUser(req);
  var fileId = req.swagger.params.fileId.value;
    Severity: Major
    Found in api/controllers/storage.js - About 3 hrs to fix

      Function getChallengeFileURL has 84 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var getChallengeFileURL = function(method, req, res, next) {
  // check authorization
  var challengeId = req.swagger.params.challengeId.value;
  var fileId = req.swagger.params.fileId.value;
  var user = auth.getSigninUser(req);
      Severity: Major
      Found in api/controllers/storage.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                function(challenge, cb) {
          if(!challenge) {
            return cb(new errors.NotFoundError('challenge'));
          }
        Severity: Major
        Found in api/controllers/storage.js and 1 other location - About 3 hrs to fix
        api/controllers/storage.js on lines 183..193

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                function(challenge, cb) {
          if(!challenge) {
            return cb(new errors.NotFoundError('challenge'));
          }
        Severity: Major
        Found in api/controllers/storage.js and 1 other location - About 3 hrs to fix
        api/controllers/storage.js on lines 88..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(sequelize, DataTypes) {

  var Scorecard = sequelize.define('Scorecard', {
    // primary key
    id: {
        Severity: Major
        Found in api/models/scorecard.js - About 2 hrs to fix

          Function exports has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(sequelize, DataTypes) {

  var Challenge = sequelize.define('Challenge', {
    // primary key
    id: {
          Severity: Major
          Found in api/models/challenge.js - About 2 hrs to fix

            Function exports has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function(sequelize, DataTypes) {
  var File = sequelize.define('File', {
    // primary key
    id: {
      type: DataTypes.BIGINT, primaryKey: true, autoIncrement: true,
            Severity: Minor
            Found in api/models/file.js - About 1 hr to fix

              Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function(sequelize, DataTypes) {
  var Submission = sequelize.define('Submission', {
    // primary key
    id: {
      type: DataTypes.BIGINT, primaryKey: true, autoIncrement: true,
              Severity: Minor
              Found in api/models/submission.js - About 1 hr to fix

                Function exports has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function(sequelize, DataTypes) {
  var Participant = sequelize.define('Participant', {
    // primary key
    id: {
      type: DataTypes.BIGINT, primaryKey: true, autoIncrement: true,
                Severity: Minor
                Found in api/models/participant.js - About 1 hr to fix

                  Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(sequelize, DataTypes) {

  var ScorecardItem = sequelize.define('ScorecardItem', {
    // primary key
    id: {
                  Severity: Minor
                  Found in api/models/scorecardItem.js - About 1 hr to fix

                    Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function(sequelize, DataTypes) {

  var Requirement = sequelize.define('Requirement', {
    // primary key
    id: {
                    Severity: Minor
                    Found in api/models/requirement.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        }, {
    tableName : 'scorecard_items',
    associate : function(models) {
      ScorecardItem.belongsTo(models.Scorecard, {foreignKey: 'scorecardId'});
      ScorecardItem.belongsTo(models.Requirement, {foreignKey: 'requirementId'});
                      Severity: Major
                      Found in api/models/scorecardItem.js and 1 other location - About 1 hr to fix
                      api/models/file.js on lines 58..65

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 62.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        }, {
    tableName : 'files',
    associate : function(models) {
      File.belongsTo(models.Challenge, {foreignKey : 'challengeId'});
      File.belongsTo(models.Submission, {foreignKey : 'submissionId'});
                      Severity: Major
                      Found in api/models/file.js and 1 other location - About 1 hr to fix
                      api/models/scorecardItem.js on lines 49..55

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 62.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      module.exports = {
    createRequirement: requirementController.create,
    getAllRequirementsByChallengeId: requirementController.all,
    getRequirements: requirementController.get,
    updateRequirement: requirementController.update,
                      Severity: Major
                      Found in api/controllers/requirements.js and 3 other locations - About 1 hr to fix
                      api/controllers/files.js on lines 25..31
                      api/controllers/scorecardItems.js on lines 32..39
                      api/controllers/scorecards.js on lines 25..32

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 57.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      module.exports = {
  getFiles: fileController.all,
  addFile: fileController.create,
  getFile: fileController.get,
  updateFile: fileController.update,
                      Severity: Major
                      Found in api/controllers/files.js and 3 other locations - About 1 hr to fix
                      api/controllers/requirements.js on lines 25..31
                      api/controllers/scorecardItems.js on lines 32..39
                      api/controllers/scorecards.js on lines 25..32

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 57.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      module.exports = {
  createScorecard: scorecardController.create,
  getAllScorecardsByChallengeId: scorecardController.all,
  getScorecardbyId: scorecardController.get,
  updateScorecard: scorecardController.update,
                      Severity: Major
                      Found in api/controllers/scorecards.js and 3 other locations - About 1 hr to fix
                      api/controllers/files.js on lines 25..31
                      api/controllers/requirements.js on lines 25..31
                      api/controllers/scorecardItems.js on lines 32..39

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 57.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                      module.exports = {
  getScoreCardItemsByScorecard: scorecardItemController.all,
  createScorecardItem: scorecardItemController.create,
  getScorecardItem: scorecardItemController.get,
  updateScorecardItem: scorecardItemController.update,
                      Severity: Major
                      Found in api/controllers/scorecardItems.js and 3 other locations - About 1 hr to fix
                      api/controllers/files.js on lines 25..31
                      api/controllers/requirements.js on lines 25..31
                      api/controllers/scorecards.js on lines 25..32

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 57.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language