Sign upLogin

appirio-tech/lc1-discussion-service

View on GitHub
Star

Showing 73 of 73 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    id: {
      type: DataTypes.BIGINT, primaryKey: true, autoIncrement: true,
      // bigserial(8bytes) is read as string in sequelize, need to convert to integer
      get: function() {
        return parseInt(this.getDataValue('id'));
Severity: Minor
Found in api/models/discussion.js and 1 other location - About 50 mins to fix
api/models/message.js on lines 10..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    id: {
      type: DataTypes.BIGINT, primaryKey: true, autoIncrement: true,
      // bigserial(8bytes) is read as string in sequelize, need to convert to integer
      get: function() {
        return parseInt(this.getDataValue('id'));
Severity: Minor
Found in api/models/message.js and 1 other location - About 50 mins to fix
api/models/discussion.js on lines 10..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

              if(!filterOne.id){
                reducedObject[key] = null;
                callback(null);
                return;
              }
Severity: Major
Found in lib/partialResponseHelper.js - About 45 mins to fix

    Function update has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function update(model, referenceModels, options, req, res, next) {
    Severity: Minor
    Found in lib/controllerHelper.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

            if (param[i]) {
        if (param[i] === ')') {
          routeHelper.addValidationError(req, 'Fields parameter must take entire pair of \'()\' .');
          return;
        } else if (!allowedCharacter(param[i])) {
      Severity: Major
      Found in lib/partialResponseHelper.js - About 45 mins to fix

        Function recursionReduce has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function recursionReduce(req, Model, Entity, Property, Fields, callback){
        Severity: Minor
        Found in lib/partialResponseHelper.js - About 45 mins to fix

          Function get has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function get(model, referenceModels, options, req, res, next) {
          Severity: Minor
          Found in lib/controllerHelper.js - About 45 mins to fix

            Function create has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function create(model, referenceModels, options, req, res, next) {
            Severity: Minor
            Found in lib/controllerHelper.js - About 45 mins to fix

              Function all has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function all(model, referenceModels, options, req, res, next) {
              Severity: Minor
              Found in lib/controllerHelper.js - About 45 mins to fix

                Function deleteMethod has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function deleteMethod(model, referenceModels, options, req, res, next) {
                Severity: Minor
                Found in lib/controllerHelper.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                    if(!filterOne.id){
                    reducedObject[key] = null;
                    callback(null);
                    return;
                  }
                  Severity: Major
                  Found in lib/partialResponseHelper.js - About 45 mins to fix

                    Function recursionReduce has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function recursionReduce(req, Model, Entity, Property, Fields, callback){
  var subObject = Entity[Property];
  if(_.isArray(subObject)){

    var tasks = [];
                    Severity: Minor
                    Found in lib/partialResponseHelper.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                          if (allowedCharacter(param[i])) {
        cache += param[i];
      } else {
        routeHelper.addValidationError(req, 'Fields parameter cannot contain character \'' + param[i] + '\' .');
        return;
                    Severity: Major
                    Found in lib/partialResponseHelper.js - About 45 mins to fix

                      Function deleteEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function deleteEntity(model, referenceModels, options, req, funcCallback) {
                      Severity: Minor
                      Found in lib/controllerHelper.js - About 35 mins to fix

                        Function _buildQueryFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function _buildQueryFilter(model, filtering, filters, req, callback) {
                        Severity: Minor
                        Found in lib/controllerHelper.js - About 35 mins to fix

                          Function updateEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function updateEntity(model, referenceModels, options, req, funcCallback) {
                          Severity: Minor
                          Found in lib/controllerHelper.js - About 35 mins to fix

                            Function _setFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            function _setFilter(req, filters, operator, field, value) {
                            Severity: Minor
                            Found in lib/paramHelper.js - About 35 mins to fix

                              Function allEntities has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              function allEntities(model, referenceModels, options, req, funcCallback) {
                              Severity: Minor
                              Found in lib/controllerHelper.js - About 35 mins to fix

                                Function createEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                function createEntity(model, referenceModels, options, req, funcCallback) {
                                Severity: Minor
                                Found in lib/controllerHelper.js - About 35 mins to fix

                                  Function getEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  function getEntity(model, referenceModels, options, req, funcCallback) {
                                  Severity: Minor
                                  Found in lib/controllerHelper.js - About 35 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language