appnexus/logistic-regression-L1

View on GitHub

Showing 7 of 7 total issues

File logistic_regression_L1.py has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Logistic Regression with L1 Penalty (Lasso)
"""

import numpy as np
Severity: Minor
Found in logistic_regression_L1/logistic_regression_L1.py - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                total_successes = matrix.map(lambda x:
                                             np.sum(x[:, -1]) * 1.).reduce(op.add)
    Severity: Major
    Found in logistic_regression_L1/logistic_regression_L1.py and 1 other location - About 1 hr to fix
    logistic_regression_L1/logistic_regression_L1.py on lines 342..343

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                total_trials = matrix.map(lambda x:
                                          np.sum(x[:, -2]) * 1.).reduce(op.add)
    Severity: Major
    Found in logistic_regression_L1/logistic_regression_L1.py and 1 other location - About 1 hr to fix
    logistic_regression_L1/logistic_regression_L1.py on lines 344..345

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                matrix = matrix.map(lambda x: np.insert(x, 0, 1., axis=1) * 1.)
    Severity: Minor
    Found in logistic_regression_L1/logistic_regression_L1.py and 1 other location - About 45 mins to fix
    logistic_regression_L1/logistic_regression_L1.py on lines 392..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                X = X.map(lambda x: np.insert(x, 0, 1., axis=1) * 1.)
    Severity: Minor
    Found in logistic_regression_L1/logistic_regression_L1.py and 1 other location - About 45 mins to fix
    logistic_regression_L1/logistic_regression_L1.py on lines 341..341

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function __calculate_optimal_betas has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def __calculate_optimal_betas(self, matrix, old_betas, lam,
                                      total_trials, precision, pyspark):
            """
            For each lambda iteration, determine the converged betas.
            It exits the loop once the pct change of betas is less than
    Severity: Minor
    Found in logistic_regression_L1/logistic_regression_L1.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __calculate_optimal_betas has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __calculate_optimal_betas(self, matrix, old_betas, lam,
    Severity: Minor
    Found in logistic_regression_L1/logistic_regression_L1.py - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language