Sign upLogin

appnexus/logistic-regression-L1

View on GitHub
Star

Showing 3 of 7 total issues

File logistic_regression_L1.py has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Logistic Regression with L1 Penalty (Lasso)
"""

import numpy as np
Severity: Minor
Found in logistic_regression_L1/logistic_regression_L1.py - About 3 hrs to fix

    Function __calculate_optimal_betas has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def __calculate_optimal_betas(self, matrix, old_betas, lam,
                                  total_trials, precision, pyspark):
        """
        For each lambda iteration, determine the converged betas.
        It exits the loop once the pct change of betas is less than
    Severity: Minor
    Found in logistic_regression_L1/logistic_regression_L1.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __calculate_optimal_betas has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __calculate_optimal_betas(self, matrix, old_betas, lam,
    Severity: Minor
    Found in logistic_regression_L1/logistic_regression_L1.py - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language