appnexus/sicksync

View on GitHub
src/doctor.js

Summary

Maintainability
C
1 day
Test Coverage

File doctor.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os from 'os';
import { spawnSync } from 'child_process';
import _ from 'lodash';
import chalk from 'chalk';
import fs from 'fs-extra';
Severity: Minor
Found in src/doctor.js - About 2 hrs to fix

    Function checkAll has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function checkAll(config) {
      console.info(chalk.yellow('* Checking if config is present...'));
    
      hasConfig()
        .then(() => {
    Severity: Minor
    Found in src/doctor.js - About 1 hr to fix

      Function hasCygwinOnWindows has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function hasCygwinOnWindows(project) {
        return new Promise((resolve, reject) => {
          let erroredCommands = [];
          function test({command, args = [], expectError}) {
            const output = spawnSync(command, args, {encoding: 'utf8'});
      Severity: Minor
      Found in src/doctor.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (_.isUndefined(project[key])) {
                console.info(chalk.red(`Project is missing:`, key));
                console.info('Please make sure your project has a', key, 'property');
                return false;
              }
        Severity: Major
        Found in src/doctor.js and 1 other location - About 1 hr to fix
        src/doctor.js on lines 185..189

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (_.isUndefined(config[key])) {
                console.info(chalk.red(`Config is missing:`, key));
                console.info('Please make sure your config has a', key, 'property');
                return false;
              }
        Severity: Major
        Found in src/doctor.js and 1 other location - About 1 hr to fix
        src/doctor.js on lines 214..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          hasConfig()
            .then(() => {
              console.info(chalk.yellow('\n* Checking config file...'));
              return configHasRightShape(config);
            })
        Severity: Major
        Found in src/doctor.js and 3 other locations - About 45 mins to fix
        src/doctor.js on lines 273..295
        src/doctor.js on lines 273..300
        src/doctor.js on lines 273..305

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status