Sign upLogin

appscot/sails-orientdb

View on GitHub
Star

Showing 63 of 63 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Edge.prototype.destroy = function destroy(criteria, cb) {
  var self = this;
  cb = cb || _.noop;
  
  // TODO: should be in a transaction
Severity: Major
Found in lib/collection/edge.js and 1 other location - About 1 day to fix
lib/collection/vertex.js on lines 39..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 270.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Vertex.prototype.destroy = function destroy(criteria, cb) {
  var self = this;
  cb = cb || _.noop;
  
  // TODO: should be in a transaction
Severity: Major
Found in lib/collection/vertex.js and 1 other location - About 1 day to fix
lib/collection/edge.js on lines 113..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 270.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Vertex.prototype.drop = function (relations, cb) {
  var self = this;
  
  // If class doesn't exist don't delete records
  if(!self.databaseClass){
Severity: Major
Found in lib/collection/vertex.js and 1 other location - About 7 hrs to fix
lib/collection/edge.js on lines 142..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Edge.prototype.drop = function (relations, cb) {
  var self = this;
  
  // If class doesn't exist don't delete records
  if(!self.databaseClass){
Severity: Major
Found in lib/collection/edge.js and 1 other location - About 7 hrs to fix
lib/collection/vertex.js on lines 69..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File connection.js has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

var Oriento = require('orientjs'),
    async = require('async'),
    _ = require('lodash'),
Severity: Minor
Found in lib/connection.js - About 5 hrs to fix

    Function exports has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (function() {

  // You'll want to maintain a reference to each connection
  // that gets registered with this adapter.
  //
    Severity: Major
    Found in lib/adapter.js - About 4 hrs to fix

      Function _getEdgeSides has 90 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Edge.prototype._getEdgeSides = function _getEdgeSides(definition, collectionsById) {
  collectionsById = collectionsById || {};
  var self = this,
      vertexA,
      vertexB;
      Severity: Major
      Found in lib/collection/edge.js - About 3 hrs to fix

        Function _parseDefinition has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Document.prototype._parseDefinition = function _parseDefinition(definition, collectionsByIdentity) {
  collectionsByIdentity = collectionsByIdentity || {};
  var collectionDef = _.cloneDeep(definition);
  
  var self = this;
        Severity: Major
        Found in lib/collection/document.js - About 3 hrs to fix

          Function exports has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = (function() {

  // You'll want to maintain a reference to each connection
  // that gets registered with this adapter.
  //
          Severity: Minor
          Found in lib/adapter.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File document.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          "use strict";

var _ = require('lodash'),
    utils = require('../utils'),
    Query = require('../query'),
          Severity: Minor
          Found in lib/collection/document.js - About 2 hrs to fix

            Function rewriteIds has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.rewriteIds = function rewriteIds(models, schema) {
  var self = this;
  var isModelsArray = _.isArray(models);
  var modelsAux = isModelsArray ? models : [models];
            Severity: Minor
            Found in lib/utils.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFetchPlan has 62 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Associations.prototype.getFetchPlan = function getFetchPlan(collectionName, criteria, fetchPlanLevel) {
  var self = this;
  fetchPlanLevel = fetchPlanLevel || 1;
  var parentSchema = self.connection.collections[collectionName].attributes;
  var fetchPlan = '';
            Severity: Major
            Found in lib/associations.js - About 2 hrs to fix

              Function serializeValues has 58 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Record.prototype.serializeValues = function serializeValues(values) {
  var self = this;
  var returnResult = {};

  Object.keys(values).forEach(function(key) {
              Severity: Major
              Found in lib/record.js - About 2 hrs to fix

                Function fetchPlanJoin has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Associations.prototype.fetchPlanJoin = function fetchPlanJoin(collectionName, criteria, cb) {
  var self = this;
  
  var opts = criteria._orientdb || {};
  var fetchPlanLevel = opts.fetchPlanLevel || self.fetchPlanLevel;
                Severity: Major
                Found in lib/associations.js - About 2 hrs to fix

                  Function extend has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.extend = function extend(parent, source){
  source = source || {};
  var child;

  if (_.isFunction(source)) {
                  Severity: Minor
                  Found in lib/utils.js - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function createCollection has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Connection.prototype.createCollection = function createCollection(collectionName, definition, cb) {
  var self = this;
  
  var collection = self.collections[collectionName];
                  Severity: Minor
                  Found in lib/connection.js - About 1 hr to fix

                    Function genericJoin has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    Associations.prototype.genericJoin = function genericJoin(collectionName, criteria, cb) {
  var self = this;
  
  // Ignore `select` from waterline core
  if ( typeof criteria === 'object') {
                    Severity: Minor
                    Found in lib/associations.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    Document.prototype.update = function update(criteria, values, cb) {
  var _query,
      record,
      where,
      self = this;
                    Severity: Minor
                    Found in lib/collection/document.js - About 1 hr to fix

                      Function find has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      Document.prototype.find = function find(criteria, cb) {
  var self = this;
  var _query, query;
  
  try {
                      Severity: Minor
                      Found in lib/collection/document.js - About 1 hr to fix

                        Function fixId has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                        Query.prototype.fixId = function fixId(original) {
  var self = this;

  return _.reduce(original, function parseClausePair(obj, val, key) {
                        Severity: Minor
                        Found in lib/query.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language