Sign upLogin

appscot/sails-orientdb

View on GitHub
Star
lib/adapter.js

Summary

Maintainability
D
1 day
Test Coverage

Function exports has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function() {

  // You'll want to maintain a reference to each connection
  // that gets registered with this adapter.
  //
Severity: Major
Found in lib/adapter.js - About 4 hrs to fix

    Function exports has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = (function() {

  // You'll want to maintain a reference to each connection
  // that gets registered with this adapter.
  //
    Severity: Minor
    Found in lib/adapter.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function increment has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        increment : function(connection, collection, criteria, field, amount, cb) {
    Severity: Minor
    Found in lib/adapter.js - About 45 mins to fix

      Function createEdge has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          createEdge : function(connection, collection, from, to, options, cb) {
      Severity: Minor
      Found in lib/adapter.js - About 45 mins to fix

        Function deleteEdges has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            deleteEdges : function(connection, collection, from, to, options, cb) {
        Severity: Minor
        Found in lib/adapter.js - About 45 mins to fix

          Function update has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              update : function(connection, collection, options, values, cb) {
          Severity: Minor
          Found in lib/adapter.js - About 35 mins to fix

            Function query has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                query : function(connection, collection, query, options, cb) {
            Severity: Minor
            Found in lib/adapter.js - About 35 mins to fix

              Function addAttribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  addAttribute: function(connection, collection, attrName, attrDef, cb) {
              Severity: Minor
              Found in lib/adapter.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      return connections[connection].find(collection, options, function(err, res){
        if (err) { return cb(err); }
        res.forEach(function(record){ utils.cleanOrientAttributes(record /*, TODO: add schema */); });
        cb(null, res);
      });
                Severity: Major
                Found in lib/adapter.js and 1 other location - About 1 hr to fix
                lib/associations.js on lines 322..326

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status