Sign upLogin

appscot/sails-orientdb

View on GitHub
Star
lib/collection/document.js

Summary

Maintainability
D
1 day
Test Coverage

Function _parseDefinition has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Document.prototype._parseDefinition = function _parseDefinition(definition, collectionsByIdentity) {
  collectionsByIdentity = collectionsByIdentity || {};
  var collectionDef = _.cloneDeep(definition);
  
  var self = this;
Severity: Major
Found in lib/collection/document.js - About 3 hrs to fix

    File document.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    "use strict";

var _ = require('lodash'),
    utils = require('../utils'),
    Query = require('../query'),
    Severity: Minor
    Found in lib/collection/document.js - About 2 hrs to fix

      Function find has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Document.prototype.find = function find(criteria, cb) {
  var self = this;
  var _query, query;
  
  try {
      Severity: Minor
      Found in lib/collection/document.js - About 1 hr to fix

        Function update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Document.prototype.update = function update(criteria, values, cb) {
  var _query,
      record,
      where,
      self = this;
        Severity: Minor
        Found in lib/collection/document.js - About 1 hr to fix

          Function destroy has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Document.prototype.destroy = function destroy(criteria, cb) {
  var _query,
      where,
      self = this;
          Severity: Minor
          Found in lib/collection/document.js - About 1 hr to fix

            Function _buildIndexes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Document.prototype._buildIndexes = function _buildIndexes() {
  var self = this;

  Object.keys(this.schema).forEach(function(key) {
    var columnName = self.schema[key].columnName ? self.schema[key].columnName : key;
            Severity: Minor
            Found in lib/collection/document.js - About 1 hr to fix

              Function find has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              Document.prototype.find = function find(criteria, cb) {
  var self = this;
  var _query, query;
  
  try {
              Severity: Minor
              Found in lib/collection/document.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  if(self.tableNameOriginal !== self.tableName){
      where.query[0] = where.query[0].replace(self.tableNameOriginal, self.tableName);
    }
              Severity: Major
              Found in lib/collection/document.js and 2 other locations - About 1 hr to fix
              lib/collection/document.js on lines 92..94
              lib/collection/document.js on lines 228..230

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  if(self.tableNameOriginal !== self.tableName){
      query.query[0] = query.query[0].replace(self.tableNameOriginal, self.tableName);
    }
              Severity: Major
              Found in lib/collection/document.js and 2 other locations - About 1 hr to fix
              lib/collection/document.js on lines 179..181
              lib/collection/document.js on lines 228..230

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  if(self.tableNameOriginal !== self.tableName){
      where.query[0] = where.query[0].replace(self.tableNameOriginal, self.tableName);
    }
              Severity: Major
              Found in lib/collection/document.js and 2 other locations - About 1 hr to fix
              lib/collection/document.js on lines 92..94
              lib/collection/document.js on lines 179..181

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status