Sign upLogin

appserver-io/webserver

View on GitHub
Star
src/AppserverIo/WebServer/Modules/Rewrite/Entities/Condition.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method __construct has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($operand, $action, $flags = array())
    {
        // Fill the default values for our members here
        $this->allowedTypes = array(
            'regex',
Severity: Minor
Found in src/AppserverIo/WebServer/Modules/Rewrite/Entities/Condition.php - About 1 hr to fix

Function matches has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function matches()
    {
        // Switching between different actions we have to take.
        // Using an if cascade as it seems to be faster than switch...case
        $result = false;
Severity: Minor
Found in src/AppserverIo/WebServer/Modules/Rewrite/Entities/Condition.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method matches has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function matches()
    {
        // Switching between different actions we have to take.
        // Using an if cascade as it seems to be faster than switch...case
        $result = false;
Severity: Minor
Found in src/AppserverIo/WebServer/Modules/Rewrite/Entities/Condition.php - About 1 hr to fix

Function prepareOperandAdditions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepareOperandAdditions()
    {
        foreach ($this->htaccessAdditions as $addition) {
            // The string has to start with an addition (any negating ! was cut of before)
            if (strpos($this->action, $addition) === 0) {
Severity: Minor
Found in src/AppserverIo/WebServer/Modules/Rewrite/Entities/Condition.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepareFilesystemOperand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepareFilesystemOperand()
    {
        if ($this->action === ConditionActions::IS_DIR || $this->action === ConditionActions::IS_EXECUTABLE || $this->action === ConditionActions::IS_FILE || $this->action === ConditionActions::IS_LINK || $this->action === ConditionActions::IS_USED_FILE) {
            if (strpos($this->operand, '?') !== false) {
                $this->operand = strstr($this->operand, '?', true);
Severity: Minor
Found in src/AppserverIo/WebServer/Modules/Rewrite/Entities/Condition.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status