Sign upLogin

apuliasoft/github-issue-labeler-integration-server

View on GitHub
Star

Showing 20 of 20 total issues

File api.py has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/python

from functools import wraps  
from flask import Blueprint, current_app, request, jsonify, redirect, session, url_for
from werkzeug import exceptions as exc
Severity: Minor
Found in app/api.py - About 5 hrs to fix

    File gitapp.py has 374 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from functools import wraps  
from datetime import datetime, timedelta
from urllib.parse import urlencode, quote, parse_qsl
import jwt
import requests
    Severity: Minor
    Found in app/github/gitapp.py - About 5 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if r.status_code != requests.codes.ok and r.status_code != requests.codes.created and r.status_code != requests.codes.no_content:
      raise OpenReqError(response=r)
      Severity: Major
      Found in app/openreq/openreq.py and 1 other location - About 2 hrs to fix
      app/openreq/openreq.py on lines 108..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if r.status_code != requests.codes.ok and r.status_code != requests.codes.created and r.status_code != requests.codes.no_content:
      raise OpenReqError(response=r)
      Severity: Major
      Found in app/openreq/openreq.py and 1 other location - About 2 hrs to fix
      app/openreq/openreq.py on lines 81..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      GitApp has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class GitApp:
  """
  Class for interfacing with git api
  
  """
      Severity: Minor
      Found in app/github/gitapp.py - About 2 hrs to fix

        Function _request has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def _request(self, method, endpoint, resource, params = {}, headers = {}, collect_all = False, func = lambda x : x):
    """
    Internal function to forge requests and track git errors or pagination
    
    Parameters:
        Severity: Minor
        Found in app/github/gitapp.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function train has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        def train(token):
  """
    Train a model from a GIT repository using OpenReq API
    ---
    tags:
        Severity: Minor
        Found in app/api.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _request has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def _request(self, method, endpoint, resource, params = {}, headers = {}, collect_all = False, func = lambda x : x):
        Severity: Major
        Found in app/github/gitapp.py - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              r = requests.post(self.API_ENDPOINT + 'train', params = { 'company': company, 'property': property }, json = { 'requirements': requirements })
          Severity: Minor
          Found in app/openreq/openreq.py and 1 other location - About 50 mins to fix
          app/openreq/openreq.py on lines 79..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              r = requests.post(self.API_ENDPOINT + 'classify', params = { 'company': company, 'property': property }, json = { 'requirements': requirements })
          Severity: Minor
          Found in app/openreq/openreq.py and 1 other location - About 50 mins to fix
          app/openreq/openreq.py on lines 106..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function setup has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def setup(self, APP_ID, CLIENT_ID, CLIENT_SECRET, PRIV_KEY_PATH, PERSONAL_ACCESS_TOKEN=None, GITHUB_LIMIT_REQUEST=False):
          Severity: Minor
          Found in app/github/gitapp.py - About 45 mins to fix

            Function classify has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def classify(token):
  """
    Classify a repository using a model trained from another repository
    ---
    tags:
            Severity: Minor
            Found in app/api.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function webhook has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def webhook(): 
  """
  WebHook endpoint
  No need to call directly
  Needed by Git as a callback endpoint to receive server side events
            Severity: Minor
            Found in app/api.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              try:
    company, property = repo.split("/")
  except ValueError:
    return jsonify({
      'message': "Repository not in the format 'owner/name' or 'organization/name'"
            Severity: Minor
            Found in app/api.py and 1 other location - About 45 mins to fix
            app/api.py on lines 222..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 35.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              try:
    company, property = model.split("/")
  except ValueError:
    return jsonify({
      'message': "Repository model not in the format 'owner/name' or 'organization/name'"
            Severity: Minor
            Found in app/api.py and 1 other location - About 45 mins to fix
            app/api.py on lines 133..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 35.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function classify has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def classify(repo, model, token, issues = None, batch=False):
            Severity: Minor
            Found in app/tasks.py - About 35 mins to fix

              Function classify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def classify(repo, model, token, issues = None, batch=False):
  """
  Asyncronous classify task.
  Retrive issues from source git repository and start a classification on OpenReq instance.
  Then update labels in the source repository and save do db.
              Severity: Minor
              Found in app/tasks.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                  return jsonify({
              Severity: Major
              Found in app/api.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return jsonify({
                Severity: Major
                Found in app/api.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return jsonify({
                  Severity: Major
                  Found in app/api.py - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language