aquaform/project-lvl2-s96

View on GitHub

Showing 45 of 45 total issues

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences in difficult JSON files', () => {
  const before = './__tests__/__fixtures__/before2.json';
  const after = './__tests__/__fixtures__/after2.json';

  expect(gendiff(before, after)).toEqual(result2);
Severity: Major
Found in __tests__/gendiff.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences in YML files', () => {
  const before = './__tests__/__fixtures__/before.yml';
  const after = './__tests__/__fixtures__/after.yml';

  expect(gendiff(before, after)).toEqual(result);
Severity: Major
Found in __tests__/gendiff.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences with difficult YML files', () => {
  const before = './__tests__/__fixtures__/before2.yml';
  const after = './__tests__/__fixtures__/after2.yml';

  expect(gendiff(before, after)).toEqual(result2);
Severity: Major
Found in __tests__/gendiffToTree.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences with difficult INI files', () => {
  const before = './__tests__/__fixtures__/before2.ini';
  const after = './__tests__/__fixtures__/after2.ini';

  expect(gendiff(before, after)).toEqual(result2);
Severity: Major
Found in __tests__/gendiffToTree.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences in simple INI files', () => {
  const before = './__tests__/__fixtures__/before.ini';
  const after = './__tests__/__fixtures__/after.ini';

  expect(gendiff(before, after)).toEqual(result);
Severity: Major
Found in __tests__/gendiffToTree.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences in JSON files', () => {
  const before = './__tests__/__fixtures__/before.json';
  const after = './__tests__/__fixtures__/after.json';

  expect(gendiff(before, after)).toEqual(result);
Severity: Major
Found in __tests__/gendiff.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences in INI files', () => {
  const before = './__tests__/__fixtures__/before.ini';
  const after = './__tests__/__fixtures__/after.ini';

  expect(gendiff(before, after)).toEqual(result);
Severity: Major
Found in __tests__/gendiff.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences with difficult JSON files', () => {
  const before = './__tests__/__fixtures__/before2.json';
  const after = './__tests__/__fixtures__/after2.json';

  expect(gendiff(before, after)).toEqual(result2);
Severity: Major
Found in __tests__/gendiffToTree.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 67..72
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

test('Generate differences in simple YML files', () => {
  const before = './__tests__/__fixtures__/before.yml';
  const after = './__tests__/__fixtures__/after.yml';

  expect(gendiff(before, after)).toEqual(result);
Severity: Major
Found in __tests__/gendiffToTree.test.js and 9 other locations - About 35 mins to fix
__tests__/gendiff.test.js on lines 30..35
__tests__/gendiff.test.js on lines 37..42
__tests__/gendiff.test.js on lines 44..49
__tests__/gendiff.test.js on lines 51..56
__tests__/gendiffToTree.test.js on lines 39..44
__tests__/gendiffToTree.test.js on lines 46..51
__tests__/gendiffToTree.test.js on lines 53..58
__tests__/gendiffToTree.test.js on lines 60..65
__tests__/gendiffToTree.test.js on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

          return `${newIndentSize}- ${node.key}: ${node.beforeValue}`;
Severity: Major
Found in src/strategies/renderAstToTree.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return renderAstToPlain(`${host}.${node.key}`, node.children);
    Severity: Major
    Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return `${newIndentSize}+ ${node.key}: ${node.afterValue}`;
      Severity: Major
      Found in src/strategies/renderAstToTree.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return `${newIndentSize}- ${node.key}: ${renderAstToTree(node.children, newIndents)}`;
        Severity: Major
        Found in src/strategies/renderAstToTree.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return `Property '${node.key}' was added with value: '${node.afterValue}'`;
          Severity: Major
          Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return `Property '${node.key}' was removed`;
            Severity: Major
            Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return buildNode({ key, type: 'unchanged', beforeValue: beforeConfig[key], afterValue: afterConfig[key] });
              Severity: Major
              Found in src/buildAstOfDiffs.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return `${newIndentSize}+ ${node.key}: ${renderAstToTree(node.children, newIndents)}`;
                Severity: Major
                Found in src/strategies/renderAstToTree.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return renderAstToPlain(node.children, node.key);
                  Severity: Major
                  Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return null;
                    Severity: Major
                    Found in src/strategies/renderAstToTree.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return buildNode({ key, type: 'unchanged', children: generateDiffs(beforeConfig[key], afterConfig[key]) });
                      Severity: Major
                      Found in src/buildAstOfDiffs.js - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language