Sign upLogin

arastta/arastta

View on GitHub
Star
admin/controller/catalog/option.php

Summary

Maintainability
F
5 days
Test Coverage

File option.php has 438 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @package     Arastta eCommerce
 * @copyright   2015-2017 Arastta Association. All rights reserved.
 * @copyright   See CREDITS.txt for credits and other copyright notices.
Severity: Minor
Found in admin/controller/catalog/option.php - About 6 hrs to fix

    Method getForm has 129 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getForm() {
        $data['heading_title'] = $this->language->get('heading_title');
        
        $data['text_form'] = !isset($this->request->get['option_id']) ? $this->language->get('text_add') : $this->language->get('text_edit');
        $data['text_choose'] = $this->language->get('text_choose');
    Severity: Major
    Found in admin/controller/catalog/option.php - About 5 hrs to fix

      Function autocomplete has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

          public function autocomplete() {
        $json = array();

        if (isset($this->request->get['filter_name'])) {
            $this->load->language('catalog/option');
      Severity: Minor
      Found in admin/controller/catalog/option.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getList has 118 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getList() {
        if (isset($this->request->get['sort'])) {
            $sort = $this->request->get['sort'];
        } else {
            $sort = 'od.name';
      Severity: Major
      Found in admin/controller/catalog/option.php - About 4 hrs to fix

        Function getForm has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getForm() {
        $data['heading_title'] = $this->language->get('heading_title');
        
        $data['text_form'] = !isset($this->request->get['option_id']) ? $this->language->get('text_add') : $this->language->get('text_edit');
        $data['text_choose'] = $this->language->get('text_choose');
        Severity: Minor
        Found in admin/controller/catalog/option.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getList has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getList() {
        if (isset($this->request->get['sort'])) {
            $sort = $this->request->get['sort'];
        } else {
            $sort = 'od.name';
        Severity: Minor
        Found in admin/controller/catalog/option.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method autocomplete has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function autocomplete() {
        $json = array();

        if (isset($this->request->get['filter_name'])) {
            $this->load->language('catalog/option');
        Severity: Major
        Found in admin/controller/catalog/option.php - About 2 hrs to fix

          Function validateForm has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function validateForm() {
        if (!$this->user->hasPermission('modify', 'catalog/option')) {
            $this->error['warning'] = $this->language->get('error_permission');
        }
          Severity: Minor
          Found in admin/controller/catalog/option.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function edit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function edit() {
        $this->load->language('catalog/option');

        $this->document->setTitle($this->language->get('heading_title'));
          Severity: Minor
          Found in admin/controller/catalog/option.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function add has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function add() {
        $this->load->language('catalog/option');

        $this->document->setTitle($this->language->get('heading_title'));
          Severity: Minor
          Found in admin/controller/catalog/option.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function delete() {
        $this->load->language('catalog/option');

        $this->document->setTitle($this->language->get('heading_title'));
          Severity: Minor
          Found in admin/controller/catalog/option.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 13 locations. Consider refactoring.
          Open

              protected function validateDelete() {
        if (!$this->user->hasPermission('modify', 'catalog/option')) {
            $this->error['warning'] = $this->language->get('error_permission');
        }
          Severity: Major
          Found in admin/controller/catalog/option.php and 12 other locations - About 2 hrs to fix
          admin/controller/catalog/attribute.php on lines 448..464
          admin/controller/catalog/attribute_group.php on lines 398..414
          admin/controller/catalog/download.php on lines 462..478
          admin/controller/catalog/manufacturer.php on lines 520..536
          admin/controller/catalog/recurring.php on lines 561..577
          admin/controller/localisation/geo_zone.php on lines 476..492
          admin/controller/localisation/return_action.php on lines 385..401
          admin/controller/localisation/return_reason.php on lines 384..400
          admin/controller/localisation/tax_class.php on lines 423..439
          admin/controller/localisation/tax_rate.php on lines 454..470
          admin/controller/sale/voucher_theme.php on lines 421..437
          admin/controller/user/user_permission.php on lines 470..486

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (isset($this->request->post['option_value'])) {
            foreach ($this->request->post['option_value'] as $option_value_id => $option_value) {
                foreach ($option_value['option_value_description'] as $language_id => $option_value_description) {
                    if ((utf8_strlen($option_value_description['name']) < 1) || (utf8_strlen($option_value_description['name']) > 128)) {
                        $this->error['option_value'][$option_value_id][$language_id] = $this->language->get('error_option_value');
          Severity: Major
          Found in admin/controller/catalog/option.php and 2 other locations - About 1 hr to fix
          admin/controller/catalog/filter.php on lines 414..422
          admin/controller/sale/custom_field.php on lines 560..568

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status