Sign upLogin

arastta/arastta

View on GitHub
Star
system/mpdf/graph.php

Summary

Maintainability
F
3 wks
Test Coverage

Function print_graph has a Cognitive Complexity of 689 (exceeds 5 allowed). Consider refactoring.
Open

function print_graph($g,$pgwidth) {
    $splines = false;
    $bandw = false;
    $percent = false;
    $show_percent = false;
Severity: Minor
Found in system/mpdf/graph.php - About 2 wks to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method print_graph has 533 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function print_graph($g,$pgwidth) {
    $splines = false;
    $bandw = false;
    $percent = false;
    $show_percent = false;
Severity: Major
Found in system/mpdf/graph.php - About 2 days to fix

    File graph.php has 558 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php


// mPDF 4.5.009
define("FF_USERFONT", 15);    // See jpgraph_ttf.inc.php for font IDs
    Severity: Major
    Found in system/mpdf/graph.php - About 1 day to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  foreach($data AS $series => $dat) { 
                $rdata = array();
                foreach($data[$series] AS $row) { $rdata[] = $row;  }

                // Create the bar plot
      Severity: Major
      Found in system/mpdf/graph.php and 1 other location - About 1 day to fix
      system/mpdf/graph.php on lines 667..691

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 246.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  foreach($data AS $series => $dat) { 
                $rdata = array();
                foreach($data[$series] AS $row) { $rdata[] = $row;  }
                // Create the bar pot
                $bplot = new BarPlot($rdata);
      Severity: Major
      Found in system/mpdf/graph.php and 1 other location - About 1 day to fix
      system/mpdf/graph.php on lines 582..607

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 246.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          else if ($dataseries=='rows') { 
        if ($colbegin>1) {
            for ($r=($rowbegin-1);$r<$rowend;$r++) { 
                $labels[($r+1-$rowbegin)] = $g['data'][$r][0] ; 
                $longestlabel = max($longestlabel , strlen( $g['data'][$r][0] ));
      Severity: Major
      Found in system/mpdf/graph.php and 1 other location - About 5 hrs to fix
      system/mpdf/graph.php on lines 184..211

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 197.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if ($dataseries=='cols') { 
        if ($colbegin>1) {
            for ($r=($rowbegin-1);$r<$rowend;$r++) { 
                $legends[($r+1-$rowbegin)] = $g['data'][$r][0] ;
                $longestlegend = max($longestlegend, strlen( $g['data'][$r][0] ));
      Severity: Major
      Found in system/mpdf/graph.php and 1 other location - About 5 hrs to fix
      system/mpdf/graph.php on lines 198..211

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 197.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status