Sign upLogin

arboleya/electrify

View on GitHub
Star

Showing 32 of 32 total issues

Function Env has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Env(input, output, settings, cli) {
  // shortcuts
  var join = path.join;

  // electrify version
Severity: Major
Found in lib/env.js - About 3 hrs to fix

    Function Env has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    function Env(input, output, settings, cli) {
  // shortcuts
  var join = path.join;

  // electrify version
    Severity: Minor
    Found in lib/env.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      if(!fs.existsSync(this.app_mongod_path)) {
    this.log.info('acquiring mongod');
    shell.cp(this.$.env.meteor.mongod, this.$.env.app.bin);
  } else
    this.log.info('mongod already acquired, moving on');
    Severity: Major
    Found in lib/plugins/mongodb.js and 2 other locations - About 3 hrs to fix
    lib/plugins/mongodb.js on lines 31..35
    lib/plugins/nodejs.js on lines 30..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      if(!fs.existsSync(this.app_mongo_path)) {
    this.log.info('acquiring mongo');
    shell.cp(this.$.env.meteor.mongo, this.$.env.app.bin);
  } else
    this.log.info('mongo already acquired, moving on');
    Severity: Major
    Found in lib/plugins/mongodb.js and 2 other locations - About 3 hrs to fix
    lib/plugins/mongodb.js on lines 37..41
    lib/plugins/nodejs.js on lines 30..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      if(!fs.existsSync(this.app_node_path)){
    this.log.info('acquiring nodejs');
    shell.cp(this.$.env.meteor.node, this.$.env.app.bin);
  } else
    this.log.info('nodejs already acquired, moving on');
    Severity: Major
    Found in lib/plugins/nodejs.js and 2 other locations - About 3 hrs to fix
    lib/plugins/mongodb.js on lines 31..35
    lib/plugins/mongodb.js on lines 37..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function start has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MongoDB.prototype.start = function(done) {

  // in development mode, when app is not inside elctron, mongodb is just not
  // needed, since meteor itself is already running its own mongodb
  if(!this.$.env.app.is_packaged) {
    Severity: Minor
    Found in lib/plugins/mongodb.js - About 1 hr to fix

      Function package has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Electron.prototype.package = function(packager_options, done) {

  var packager = require('electron-packager');

  // fetches electron version from core temp folder
      Severity: Minor
      Found in lib/electron.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if(program.input && !fs.existsSync(program.input)) {
    console.error('input folder doesn\'t exist\n  ' + program.input);
    process.exit();
  }
        Severity: Major
        Found in bin/cli.js and 1 other location - About 1 hr to fix
        bin/cli.js on lines 160..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if(program.input && !fs.existsSync(program.input)) {
    console.error('input folder doesn\'t exist\n  ' + program.input);
    process.exit();
  }
        Severity: Major
        Found in bin/cli.js and 1 other location - About 1 hr to fix
        bin/cli.js on lines 113..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function Socket has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Socket($, logger){
  this.$ = $;
  this.log = require('../log')($, 'electrify:plugins:socket');
  
  this.name = 'socket';
        Severity: Minor
        Found in lib/plugins/socket.js - About 1 hr to fix

          Function prepare has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Scaffold.prototype.prepare = function() {

  this.log.info('ensuring basic structure');
  
  shell.mkdir('-p' , this.$.env.app.bin);
          Severity: Minor
          Found in lib/scaffold.js - About 1 hr to fix

            Function parse_packager_options has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function parse_packager_options(){
  var names = [
    '--icon',
    '--app-bundle-id',
    '--app-version',
            Severity: Minor
            Found in bin/cli.js - About 1 hr to fix

              Function electrify has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function electrify(create) {
  var input;

  // validates input dir (app-root folder)
  if(program.input && !fs.existsSync(program.input)) {
              Severity: Minor
              Found in bin/cli.js - About 1 hr to fix

                Function setup has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                target.setup = function() {
  log('setting up everything for development');

  // list folder paths
  var parent       = path.join(__dirname, '..');
                Severity: Minor
                Found in make.js - About 1 hr to fix

                  Function connect has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function connect(port){

  if(!port) {
    log([
      'cannot initialize connection. Did you `npm install -g electrify`?',
                  Severity: Minor
                  Found in meteor/index.js - About 1 hr to fix

                    Function ensure_deps has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    App.prototype.ensure_deps = function(done) {

  this.log.info('ensuring electrify dependencies');
  
  var npm_cmd = 'npm' + (this.$.env.os.is_windows ? '.cmd' : '');
                    Severity: Minor
                    Found in lib/app.js - About 1 hr to fix

                      Function bundle_meteor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      App.prototype.bundle_meteor = function( /* server_url, */ done) {
  this.log.info('bundling meteor');

  var tmp_dir             = join(this.$.env.core.tmp, 'bundling');
  var bundled_dir         = join(tmp_dir, 'bundle');
                      Severity: Minor
                      Found in lib/app.js - About 1 hr to fix

                        Function electrify has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function electrify(create) {
  var input;

  // validates input dir (app-root folder)
  if(program.input && !fs.existsSync(program.input)) {
                        Severity: Minor
                        Found in bin/cli.js - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 5 locations. Consider refactoring.
                        Open

                        Log.prototype.trace = function(){
  if(/TRACE|ALL/i.test(level()))
    log(this.prefix, 'TRACE', slice(arguments));
};
                        Severity: Major
                        Found in lib/log.js and 4 other locations - About 50 mins to fix
                        lib/log.js on lines 20..23
                        lib/log.js on lines 25..28
                        lib/log.js on lines 30..33
                        lib/log.js on lines 35..38

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 52.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 5 locations. Consider refactoring.
                        Open

                        Log.prototype.debug = function(){
  if(/DEBUG|ALL/i.test(level()))
    log(this.prefix, 'DEBUG', slice(arguments));
};
                        Severity: Major
                        Found in lib/log.js and 4 other locations - About 50 mins to fix
                        lib/log.js on lines 20..23
                        lib/log.js on lines 25..28
                        lib/log.js on lines 30..33
                        lib/log.js on lines 40..43

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 52.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language