Sign upLogin

archan937/magnum-pi

View on GitHub
Star

Showing 10 of 10 total issues

Method finalize_element has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def finalize_element
    if element = elements.pop
      values = element.delete :values
      index = element.delete :index
      if text = element.delete(:text)
Severity: Minor
Found in lib/magnum-pi/gem_ext/ox/ax.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_value has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def process_value(name, args, block)
        value = args[0]
        if name == :resources
          (_values[name] ||= {}).merge! value
        else
Severity: Minor
Found in lib/magnum-pi/api/scheme.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def request(method, url, params)
        puts "#{method.upcase} #{url} #{"(#{params.inspect[1..-2]})" if params && params.size > 0}" if MagnumPI.debug_output?
        args = [method, url, params]
        args << nil if method.to_s.upcase == "GET"
        args << request_headers(method, url, params)
Severity: Minor
Found in lib/magnum-pi/api/consumer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetch_with_retry has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        uri,
        method    = :get,
        headers   = {},
        params    = [],
        referer   = current_page,
Severity: Minor
Found in lib/magnum-pi/gem_ext/mechanize/http/agent.rb - About 45 mins to fix

    Method fetch_with_retry has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def fetch_with_retry(
        uri,
        method    = :get,
        headers   = {},
        params    = [],
    Severity: Minor
    Found in lib/magnum-pi/gem_ext/mechanize/http/agent.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method download has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def download(target, method, *args)
        url, params = parse_args *args
        File.delete target if File.exists? target
        FileUtils.mkdir_p File.dirname(target)
        file = File.open target, "w"
    Severity: Minor
    Found in lib/magnum-pi/api/consumer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def entry?
    @regexp ||= begin
      pattern = @pattern.join(%q{\/}).gsub("*", %q{[^\/]+})
      Regexp.new "^#{pattern}$"
    end
    Severity: Minor
    Found in lib/magnum-pi/gem_ext/oj/aj.rb and 1 other location - About 15 mins to fix
    lib/magnum-pi/gem_ext/ox/ax.rb on lines 79..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def entry?
    @regexp ||= begin
      pattern = @pattern.join(%q{\/}).gsub("*", %q{[^\/]+})
      Regexp.new "^#{pattern}$"
    end
    Severity: Minor
    Found in lib/magnum-pi/gem_ext/ox/ax.rb and 1 other location - About 15 mins to fix
    lib/magnum-pi/gem_ext/oj/aj.rb on lines 91..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class Hash

  def deep_clone(cache = {})
    return cache[self] if cache.key?(self)
    Severity: Minor
    Found in lib/magnum-pi/core_ext/deep_clone.rb and 1 other location - About 15 mins to fix
    lib/magnum-pi/core_ext/deep_clone.rb on lines 35..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class Array

  def deep_clone(cache = {})
    return cache[self] if cache.key?(self)
    Severity: Minor
    Found in lib/magnum-pi/core_ext/deep_clone.rb and 1 other location - About 15 mins to fix
    lib/magnum-pi/core_ext/deep_clone.rb on lines 51..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language