Sign upLogin

archangel/archangel

View on GitHub
Star
app/controllers/api/v1/collections/collection_entries_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def resource_create_object
          entry_resource = @collection.collection_entries.new(nil)

          collection_field_key_map.each do |field|
            entry_resource.assign_attributes(field => resource_params.fetch(field, nil))
Severity: Minor
Found in app/controllers/api/v1/collections/collection_entries_controller.rb and 1 other location - About 25 mins to fix
app/controllers/manage/collections/collection_entries_controller.rb on lines 183..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        def update
          respond_to do |format|
            if @collection_entry.update(resource_params)
              format.json { render :update, status: :accepted }
            else
Severity: Minor
Found in app/controllers/api/v1/collections/collection_entries_controller.rb and 5 other locations - About 20 mins to fix
app/controllers/api/v1/collections_controller.rb on lines 77..82
app/controllers/api/v1/contents_controller.rb on lines 73..78
app/controllers/api/v1/profiles_controller.rb on lines 21..26
app/controllers/api/v1/sites_controller.rb on lines 26..31
app/controllers/api/v1/users_controller.rb on lines 65..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        def create
          respond_to do |format|
            if @collection_entry.save
              format.json { render :create, status: :created }
            else
Severity: Minor
Found in app/controllers/api/v1/collections/collection_entries_controller.rb and 2 other locations - About 15 mins to fix
app/controllers/api/v1/collections_controller.rb on lines 63..68
app/controllers/api/v1/contents_controller.rb on lines 59..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status