archanox/RGBDS2CIL

View on GitHub

Showing 278 of 278 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            var code = CommentRegex.Replace(fileLine, me => me.Value.StartsWith(";") ? me.Groups[2].Value : me.Value).Trim();
Severity: Minor
Found in RGBDS2CIL/Parser.cs and 1 other location - About 35 mins to fix
RGBDS2CIL/Parser.cs on lines 404..404

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Unexpected spaces found.
Open

namespace RGBDS2CIL

XXX found
Open

        DB      %..XXX...
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

Unexpected spaces found.
Open

namespace RGBDS2CIL
Severity: Minor
Found in RGBDS2CIL/Lines/EndLoadLine.cs by editorconfig

XXX found
Open

        DB      %..XXX...
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

XXX found
Open

        DB      %XXX..XX.
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

XXX found
Open

        DB      %.XXX.XX.
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

Unexpected spaces found.
Open

using System;
Severity: Minor
Found in RGBDS2CIL/Lines/AssertLine.cs by editorconfig

Unexpected spaces found.
Open

namespace RGBDS2CIL

Unexpected spaces found.
Open

namespace RGBDS2CIL

Unexpected spaces found.
Open

using System.Linq;
Severity: Minor
Found in RGBDS2CIL/Lines/LoadLine.cs by editorconfig

XXX found
Open

        DB      %XXX..XXX
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

XXX found
Open

        DB      %XXX..XXX
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

XXX found
Open

        DB      %....XXX.
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

XXX found
Open

        DB      %..XXX...
Severity: Minor
Found in Assembly/IBMPC1.INC by fixme

Unexpected spaces found.
Open

using System.Linq;
Severity: Minor
Found in RGBDS2CIL/Lines/AddLine.cs by editorconfig

Unexpected spaces found.
Open

using System;
Severity: Minor
Found in RGBDS2CIL/Lines/DefineLine.cs by editorconfig

Unexpected spaces found.
Open

using System.Text;

Unexpected spaces found.
Open

using System.Collections.Generic;

Unexpected spaces found.
Open

namespace RGBDS2CIL
Severity
Category
Status
Source
Language